fix: harden Psalm with server-aware context and related signing fixes#7891
Open
vitormattos wants to merge 15 commits into
Open
fix: harden Psalm with server-aware context and related signing fixes#7891vitormattos wants to merge 15 commits into
vitormattos wants to merge 15 commits into
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
a56958c to
9192c41
Compare
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR hardens LibreSign's Psalm setup while cleaning up the related code paths that surfaced during the tightening work.
ActiveSigningsServicefromAdminControllerand adds focused unit coveragenextcloud/servertype context, including server-ownedOCA/*,sabre/*, anddoctrine/dbaldependenciesnextcloud/servercheckout instead of duplicating server 3rdparty packages in LibreSigntwofactor_gatewayintegration by delegating to the upstreamGatewayDirectIntegrationService🔜 Follow-up
A full exploratory Psalm run with
errorLevel="1"still reports real code issues, so this PR intentionally stops at infrastructure and targeted ratcheting instead of lowering the global level in one jump.The next focused cleanup should target the issue families that showed up most often:
Mixed*ClassMustBeFinalRiskyTruthyFalsyComparisonPossiblyNullReferenceandPossiblyNullArgumentOnce those families are reduced in focused follow-up PRs, we can safely revisit lowering the global Psalm error level.