Skip the release build job on pull requests from forks#474
Open
ElCruncharino wants to merge 1 commit into
Open
Skip the release build job on pull requests from forks#474ElCruncharino wants to merge 1 commit into
ElCruncharino wants to merge 1 commit into
Conversation
Fork PRs cannot access the keystore secrets, so the decoded release.pfk is empty and assembleRelease always fails with a signing error. The job now runs only on pushes and same-repo PRs, while build-debug and the linter keep covering fork PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build job signs a release apk with the keystore from the repo secrets. Secrets are not available to pull requests coming from forks, so the decoded release.pfk is empty and assembleRelease always fails with a signing error there (see the checks on #471, #472, #473 for example). This makes every external PR show a red cross even when the code is fine.
This skips the release job for fork PRs while keeping it for pushes and same-repo PRs. Fork PRs are still covered by the linter and the debug build.