Allow using search without being logged in#475
Open
ElCruncharino wants to merge 1 commit into
Open
Conversation
Fixes LivingWithHippos#302. The bottom nav search item was in the same disabled list as the downloads/lists item, so it stayed greyed out until a Real-Debrid login completed, even though plugin search itself doesn't need an account. Removed navigation_search from both disableBottomNavItems calls in MainActivity so the tab is reachable right away, matching what the maintainer suggested in the issue thread. Tapping a result to unrestrict/download still requires login and falls back to the existing please_login toast, since that part genuinely needs an authenticated session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search tab was disabled until the user logged in, even though the plugin-based scraper search itself never touches the Real-Debrid API. Removed it from the list of bottom nav items that get disabled before authentication, matching what the maintainer suggested in the issue.
Tapping a search result to download still needs a login, and falls back to the existing "please login" message instead of doing anything else, so this is a partial fix as expected, just enough to make the tab itself usable.
Closes #302