Apply theme changes instantly instead of requiring a restart#476
Open
ElCruncharino wants to merge 1 commit into
Open
Apply theme changes instantly instead of requiring a restart#476ElCruncharino wants to merge 1 commit into
ElCruncharino wants to merge 1 commit into
Conversation
Picking a new theme now recreates the current activity right away. Since the app has two activities (MainActivity and SettingsActivity), ThemingCallback also checks on every activity resume whether the saved theme differs from what that activity was created with, and recreates it too, so MainActivity picks up the change as soon as you back out of Settings instead of needing a full app restart. Removes the now-inaccurate "restart to apply" summary and string.
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking a new theme in Settings used to just save the preference and show a toast telling you to restart the app for it to take effect. Now it recreates the current screen right away, so the change shows immediately.
Since the app has two activities, the settings screen and the main one, ThemingCallback also checks on every screen resume whether the saved theme has changed since that screen was created, and recreates it too. That way going back from Settings to the main screen already shows the new theme instead of needing a full app restart.
Removed the now incorrect "restart to apply" text since it no longer applies.