Move cache clearing off the main thread#477
Open
ElCruncharino wants to merge 1 commit into
Open
Conversation
clearCache did a recursive file delete synchronously in MainActivityViewModel, and MainActivity called it directly in onCreate. That blocked the UI thread with disk I/O on every cold start. The cleanup now runs inside viewModelScope.launch(Dispatchers.IO), keeping clearCache non-suspend so the call site in MainActivity does not need any changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MainActivityViewModel.clearCache does a recursive delete over the cache directory, and it was running synchronously on whatever thread called it, which in this case is the main thread on every app start. Wrapped it in viewModelScope.launch(Dispatchers.IO) so the disk work happens off the main thread. As the cache grows this was a real path to startup jank.