Feature/take group improvements#388
Open
MutazAshhab wants to merge 7 commits into
Open
Conversation
Mhudlark
reviewed
Oct 17, 2022
|
|
||
| useKeypressWithEvent( | ||
| handleKeypressWithEvent, | ||
| true, |
Collaborator
There was a problem hiding this comment.
Instead of true, could this be isTakeGroupOpened?
emmapainter
requested changes
Oct 18, 2022
Collaborator
There was a problem hiding this comment.
Thanks for doing this!
For some reason there is some unexpected behaviour. I tried to take a screen recording but since I was using keyboard shortcuts it isn't clear what I'm doing. Here's what happened:
- Open a take group
- Using number keys to toggle between takes works great!
- Press enter to confirm current selection - still working as expected
- Reopen the take group by clicking the take indicator
- Use number keys to toggle between takes - now it does some funky behaviour where it starts selecting takes for other take groups?
Here's the screen recording:
https://user-images.githubusercontent.com/100325471/196321701-b217f1b5-645d-4a89-a2bc-53b884db12f8.mov
Also if I press enter while no take groups are active but no takes have been selected it starts selecting takes on the take groups (should do nothing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why is this change needed?
Feature
Demo
TakeGroupShortcutsDemo.mp4
OS