Skip to content

Feature/take group improvements#388

Open
MutazAshhab wants to merge 7 commits into
developfrom
feature/take-group-improvements
Open

Feature/take group improvements#388
MutazAshhab wants to merge 7 commits into
developfrom
feature/take-group-improvements

Conversation

@MutazAshhab

Copy link
Copy Markdown
Collaborator

Summary

  • Users can now choose takes by pressing the the digits on their keyboard (numpad digits as well)
  • Users can now close take group by pressing enter (numpad enter as well). Pressing this will close the take group.

Why is this change needed?

Feature


Demo

TakeGroupShortcutsDemo.mp4

OS

  • Linux
  • MacOS
  • Windows


useKeypressWithEvent(
handleKeypressWithEvent,
true,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of true, could this be isTakeGroupOpened?

@emmapainter emmapainter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

For some reason there is some unexpected behaviour. I tried to take a screen recording but since I was using keyboard shortcuts it isn't clear what I'm doing. Here's what happened:

  1. Open a take group
  2. Using number keys to toggle between takes works great!
  3. Press enter to confirm current selection - still working as expected
  4. Reopen the take group by clicking the take indicator
  5. Use number keys to toggle between takes - now it does some funky behaviour where it starts selecting takes for other take groups?

Here's the screen recording:
https://user-images.githubusercontent.com/100325471/196321701-b217f1b5-645d-4a89-a2bc-53b884db12f8.mov

Also if I press enter while no take groups are active but no takes have been selected it starts selecting takes on the take groups (should do nothing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants