You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds the official MYNN-EDMF and MYNN-SFC submodules to MPAS with via manage_externals. Some notes on the implementation are below:
The submodules were added simultaneously due to the common package (bl_mynnedmf_in) used for both schemes (following the previous implementations).
Two additional packages are added to control the allocation of 10 optional 3d output arrays and 5 tke budget arrays.
a new cloudiness option is added to handle the processing of the MYNN-EDMF subgrid clouds analogous to radiation driver in WRF.
The implementation was complicated by the earlier implementation of MYNN schemes, so renaming of key modules and subroutines was required to allow both submodules to work as alternatives to the other versions. The other schemes should still work but will hopefully be removed.
I think the code is generally looking good from a software perspective. With PR #1460, which went in to the v8.4.1 release and modified packages for various surface fields, I think there will now be merge conflicts with the develop branch. @joeolson42 would you be able to rebase this PR branch onto the HEAD of the develop branch to resolve these conflicts? Or, if you'd like, I can help with this, as I'm familiar with the changes from #1460 that caused the merge conflicts.
Also, to accommodate changes in #1460, I think we'll need to add 'sf_mynnsfclay' to the list of valid surface layer schemes in the logic for the sfclayer package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the official MYNN-EDMF and MYNN-SFC submodules to MPAS with via manage_externals. Some notes on the implementation are below: