chore: remove dead code and unused items#831
Merged
Merged
Conversation
dacrab
force-pushed
the
refactor/dead-code-cleanup
branch
from
df65659 to
810f92e
Compare
- Remove unused StaticIcon::Copy variant - Remove unused generic on SubmenuEntry - Remove unused #[allow(unused)] from ServiceEvent - Move use StreamExt to module level in app.rs and ipc.rs
dacrab
force-pushed
the
refactor/dead-code-cleanup
branch
from
810f92e to
4862680
Compare
Collaborator
|
looks good |
romanstingler
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up several small dead-code issues:
StaticIcon::Copyvariant (+ codepoint mapping)SubmenuEntry(alwaysMessage)#[allow(unused)]fromServiceEvent(all variants used)use StreamExtto module level inapp.rsandipc.rs