sql: Reject CREATE [MATERIALIZED] VIEW with too few column names#37851
Open
def- wants to merge 1 commit into
Open
sql: Reject CREATE [MATERIALIZED] VIEW with too few column names#37851def- wants to merge 1 commit into
def- wants to merge 1 commit into
Conversation
CREATE VIEW v (name) AS SELECT 'jon', 12 silently renamed only a prefix of the query's columns. Require the column name list, when given, to match the query's arity exactly, matching the existing rejection of lists that name more columns. Sources and CTE aliases keep the lenient prefix-rename behavior. The new check is lifted while re-planning persisted catalog items, signaled by the unsafe_enable_incomplete_view_column_lists flag that is force-enabled during item parsing, so views an earlier version accepted keep loading during bootstrap instead of crash-looping environmentd. Tested with sqllogictest (regressions.slt, materialized_views.slt) and a platform check that pins restart/upgrade survival of grandfathered views. Closes: SQL-455 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE VIEW v (name) AS SELECT 'jon', 12 silently renamed only a prefix of the query's columns. Require the column name list, when given, to match the query's arity exactly, matching the existing rejection of lists that name more columns. Sources and CTE aliases keep the lenient prefix-rename behavior.
The new check is lifted while re-planning persisted catalog items, signaled by the unsafe_enable_incomplete_view_column_lists flag that is force-enabled during item parsing, so views an earlier version accepted keep loading during bootstrap instead of crash-looping environmentd.
Tested with sqllogictest (regressions.slt, materialized_views.slt) and a platform check that pins restart/upgrade survival of grandfathered views.
Closes: SQL-455