sql: apply SELECT list table functions after the reduce#37856
Open
def- wants to merge 1 commit into
Open
Conversation
A table function in the SELECT list was always joined to the FROM relation before planning GROUP BY, aggregates, and HAVING. The reduce then removed the function's columns from scope, so planning the SELECT list failed with `column "table_func_0" does not exist`. Join the table functions on top of the reduce instead, so they apply to the reduced rows and their arguments can refer to grouping columns. The pre-reduce join is kept when a group key or an aggregate references the functions' columns, e.g. when grouping by a SELECT list alias of a table function, so that grouping over a function's output keeps working. Closes: SQL-479 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A table function in the SELECT list was always joined to the FROM relation before planning GROUP BY, aggregates, and HAVING. The reduce then removed the function's columns from scope, so planning the SELECT list failed with
column "table_func_0" does not exist.Join the table functions on top of the reduce instead, so they apply to the reduced rows and their arguments can refer to grouping columns. The pre-reduce join is kept when a group key or an aggregate references the functions' columns, e.g. when grouping by a SELECT list alias of a table function, so that grouping over a function's output keeps working.
Closes: SQL-479