storage: make MySQL snapshot wait_timeout a configurable system var#37875
Open
peterdukelarsen wants to merge 1 commit into
Open
storage: make MySQL snapshot wait_timeout a configurable system var#37875peterdukelarsen wants to merge 1 commit into
peterdukelarsen wants to merge 1 commit into
Conversation
Replace the hardcoded 28800 second wait_timeout on idle MySQL snapshot connections with a new mysql_source_snapshot_wait_timeout system parameter, joining the other MySQL source timeouts that are synchronized from LaunchDarkly. The default remains 28800 seconds, the MySQL server default. Values outside the valid server range of [1, 31536000] fall back to the default, matching how the sibling timeouts are validated in TimeoutConfig::build. Extends the mysql-cdc testdrive file with a smoke test that sets the parameter and snapshots a source under it. The parameter is also added to the LaunchDarkly flag consistency allowlist alongside its siblings until flags for this family exist.
peterdukelarsen
force-pushed
the
pl/mysql-wait-timeout-flag
branch
from
July 24, 2026 18:20
e7d9b50 to
b8a090b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of SS-97.
We hold connections open while getting the count, read locks, and partitions (if enabled) on mysql snapshot. I've been playing around with Materialize and MySQL with a big table ~1B rows and this first step takes ~1.7 hours to grab the counts and partitions. I think we should make this configurable in case this becomes a limiting factor for giant tables.
Description
Makes the snapshot wait timeout configurable via launch darkly.
Verification