storage: default MySQL snapshot PK-range parallelism to off#37879
Open
peterdukelarsen wants to merge 1 commit into
Open
storage: default MySQL snapshot PK-range parallelism to off#37879peterdukelarsen wants to merge 1 commit into
peterdukelarsen wants to merge 1 commit into
Conversation
Flip the mysql_source_snapshot_parallelism dyncfg default from true to false, so new deployments use the legacy single-worker-per-table snapshot unless the flag is enabled. Parallel PK-range snapshotting stays available behind the flag and is now rolled out selectively via LaunchDarkly rather than being on everywhere by default. CI continues to run with the flag enabled through the mzcompose default system parameters, so the parallel path keeps its test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Scale tests are showing that for large MySQL tables this change does not improve performance. I tested on a 1B row table and while the test is still running, the old version is on pace to complete faster than the parallelized implementation.
Description
Defaults MySQL parallelism to be off. It does not disable the new parallelism-supporting structure.
Verification