Skip to content

Use vitest for benchmarks#43

Merged
Minhir merged 1 commit into
mainfrom
add-bench
Oct 26, 2025
Merged

Use vitest for benchmarks#43
Minhir merged 1 commit into
mainfrom
add-bench

Conversation

@Minhir

@Minhir Minhir commented Oct 26, 2025

Copy link
Copy Markdown
Owner

No description provided.

@Minhir Minhir requested a review from Copilot October 26, 2025 20:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the benchmarking system from the legacy benchmark package to Vitest's built-in benchmarking capabilities. The change modernizes the benchmark setup, adds new comparison libraries, and consolidates the benchmark configuration into the main project structure.

  • Replaced the Node.js-based benchmark runner with Vitest's bench API
  • Added faker for more comprehensive random data generation
  • Updated the benchmark methodology to test multiple operations (write, read, update, has, delete) across different dataset sizes

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Added bench script, updated vitest to v4, added benchmark dependencies to devDependencies
biome.json Expanded file includes pattern to cover nested directories while excluding build outputs
benchmark/package.json Removed standalone benchmark package configuration
benchmark/maps.bench.ts New comprehensive benchmark suite using Vitest with multiple operations and dataset sizes
benchmark/index.js Removed legacy benchmark implementation
benchmark/.gitignore Removed as benchmark directory no longer has its own node_modules
README.md Simplified benchmark documentation, removed detailed tables in favor of referencing the source file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Minhir Minhir merged commit 738c905 into main Oct 26, 2025
2 checks passed
@Minhir Minhir deleted the add-bench branch October 26, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants