Skip to content

New option -fem replacing -nofem#298

Open
corentin-prigent wants to merge 20 commits into
MmgTools:developfrom
corentin-prigent:feature/split-nonrid-edg-connecting-rid-pts
Open

New option -fem replacing -nofem#298
corentin-prigent wants to merge 20 commits into
MmgTools:developfrom
corentin-prigent:feature/split-nonrid-edg-connecting-rid-pts

Conversation

@corentin-prigent

@corentin-prigent corentin-prigent commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

This update removes the option -nofem and adds a new option -fem which takes an integer as a parameter:

mmg2d source code has been modified only in order to match the new options of mmg3d. No new features have been added to mmg2d.

@codecov

codecov Bot commented Apr 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.29%. Comparing base (4e2f535) to head (2ba54f5).
⚠️ Report is 33 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #298      +/-   ##
===========================================
- Coverage    50.31%   50.29%   -0.03%     
===========================================
  Files          177      177              
  Lines        47881    47852      -29     
  Branches     10362    10358       -4     
===========================================
- Hits         24093    24067      -26     
- Misses       16047    16051       +4     
+ Partials      7741     7734       -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@taupalosaurus

Copy link
Copy Markdown
Contributor

Also, can you please update the comments documenting info.setfem and info.fem in libmmgtypes.h

@taupalosaurus

Copy link
Copy Markdown
Contributor

And add a test for option setfem=2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants