Skip to content

feat: Add row_changes_cap_per_file parameter to datasets comparer#1747

Merged
jcpitre merged 4 commits into
mainfrom
feat/gtfs-comparer-row-changes-cap
Jun 25, 2026
Merged

feat: Add row_changes_cap_per_file parameter to datasets comparer#1747
jcpitre merged 4 commits into
mainfrom
feat/gtfs-comparer-row-changes-cap

Conversation

@jcpitre

@jcpitre jcpitre commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Adds an optional row_changes_cap_per_file parameter to the gtfs_datasets_comparer HTTP function, controlling the maximum number of row-level change entries included per file in the generated changelog. Defaults to 10000 to prevent excessively large outputs on big feeds. Set to 0 to omit row-level detail entirely, or null for no cap.

Invalid (non-integer) values are rejected early with a clear error message rather than bubbling up as a generic exception.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@jcpitre jcpitre changed the title feat: Add row_changes_cap_per_file parameter (default 10000) to datasets comparer feat: Add row_changes_cap_per_file parameter to datasets comparer Jun 23, 2026
@jcpitre jcpitre marked this pull request as draft June 25, 2026 13:28
@jcpitre jcpitre marked this pull request as ready for review June 25, 2026 13:43

@davidgamez davidgamez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcpitre jcpitre merged commit 20c2806 into main Jun 25, 2026
28 of 29 checks passed
@jcpitre jcpitre deleted the feat/gtfs-comparer-row-changes-cap branch June 25, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants