Fix controller reconnect detection#629
Draft
NicholasBellDev wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #623.
Summary
This updates controller reconnect handling so a controller sleep/wake cycle is detected even when the raw controller count stays the same.
The controller manager now compares the full controller map and validates whether the currently selected controller is still open before deciding there is nothing to update. SDL and GLFW controllers also tolerate repeated close/is-open checks without dereferencing a null native handle.
For SDL, joystick and game controller state is refreshed before opening, attachment checks, and device enumeration. This helps SDL observe Bluetooth controller sleep/wake transitions before Controllable decides whether to reconnect or auto-select a controller.
Validation
git diff --checkLocal Gradle compilation could not complete in this checkout because required MrCrayfish artifacts (
framework-*,controllable-sdl) were not resolvable from the configured public repositories, and the loader-excluded compile path hit local Java toolchain provisioning for Java 25.