Feature 2337 traefik ingress#2339
Open
artntek wants to merge 26 commits into
Open
Conversation
taojing2002
reviewed
Jul 3, 2026
| <copy todir="${war.webinf.scripts}" filtering="yes"> | ||
| <fileset dir="src/scripts"/> | ||
| </copy> | ||
| <copy todir="${war.webinf.scripts}" |
Contributor
There was a problem hiding this comment.
Just wondering if it is accidental to removing the code.
taojing2002
reviewed
Jul 3, 2026
| } | ||
| } | ||
|
|
||
| if (dn != null && !dn.trim().equals("")) { |
Contributor
There was a problem hiding this comment.
Can we replace !dn.trim().equals("") by !dn.isBlank()?
taojing2002
reviewed
Jul 3, 2026
| * Get the session from the header of the request. This mechanism is disabled by default due | ||
| * to network security conditions needed for it to be secure | ||
| */ | ||
| protected void getSessionFromHeader() { |
Contributor
There was a problem hiding this comment.
Is it possible to write a test method for it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #2337