docs: MSC cloud checkpointing + expose multi-storage-client under [s3]#2517
Open
edjson wants to merge 12 commits into
Open
docs: MSC cloud checkpointing + expose multi-storage-client under [s3]#2517edjson wants to merge 12 commits into
edjson wants to merge 12 commits into
Conversation
jgerh
reviewed
Jun 11, 2026
jgerh
left a comment
Contributor
There was a problem hiding this comment.
Completed tech pubs review of docs/guides/checkpointing.md and provided a few copyedits.
…odel[s3] installs MSC Signed-off-by: edjson <edisonggacc@gmail.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: edjson <edisonggacc@gmail.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: edjson <edisonggacc@gmail.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: edjson <edisonggacc@gmail.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: edjson <edisonggacc@gmail.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: edjson <edisonggacc@gmail.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: edjson <edisonggacc@gmail.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: edjson <edisonggacc@gmail.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: edjson <edisonggacc@gmail.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: edjson <edisonggacc@gmail.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: edjson <edisonggacc@gmail.com>
b22542f to
e36d131
Compare
Contributor
|
@edjson the PR looks good can you please resolve the conflict issues?. |
Signed-off-by: edjson <edisonggacc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Documents MSC cloud (S3) checkpointing and fixes the [s3] extra so
pip install nemo_automodel[s3]installsmulti-storage-client.Changelog
docs/guides/checkpointing.md.multi-storage-client>=0.13to the[s3]extraBefore your PR is "Ready for review"
Pre checks:
the MSC implementation and its unit tests are merged in feat: add MSC cloud storage support for dcp checkpoints #1709 . This is docs and a one line packaging fix.
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Follow up to #1709. This closes the two remaining gaps raised by @krishnakalyan3 : expose the dependency under
[s3], and document MSC configuration. Verified pip installnemo_automodel[s3]now imports both boto3 and multistorageclient.