fix(wandb): log different val datasets separately in wandb#2526
Open
grgkovac wants to merge 3 commits into
Open
fix(wandb): log different val datasets separately in wandb#2526grgkovac wants to merge 3 commits into
grgkovac wants to merge 3 commits into
Conversation
Signed-off-by: Grgur Kovac <grgur.kovac@noxtua.com>
Contributor
|
/ok to test 1db9ea9 |
Contributor
Author
|
@akoumpa the L2_HF_PEFT failure looks unrelated to this PR. Do you mind rerunning the tests? |
Contributor
|
/ok to test bfbe695 |
Contributor
|
Thanks @grgkovac ; restarted CI now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes a bug with logging multiple val datasets to wandb. They all write in Charts/val_loss, and the last val dataset overwrites the previous ones. This fix logs different val datasets in different sections. See screenshots below.
Changelog
nemo_automodel/recipes/llm/train_ft.pyvalidation dataset:in the yaml) -> same as beforeBefore your PR is "Ready for review"
Pre checks:
Additional Information
Two dummy val datasets are used for testing: dummy_number dummy_letters.
After the fix - two section one dummy_letters one dummy_numbers
Before the fix - one val_loss in Charts (dummy_letters under the name val_loss, dummy_numbers not logged)
After the fix one val dataset with custom name (
validation_dataset_dummy_letters:in yaml) - separate sectionAfter the fix one val dataset with default name (
validation_dataset:in yaml) - val_loss in Charts as before