add streaming beam search for cache aware models to NeMo inference#15768
add streaming beam search for cache aware models to NeMo inference#15768lilithgrigoryan wants to merge 30 commits into
Conversation
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
|
[🤖]: Hi @lilithgrigoryan 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
…/streaming-beam-search-niva-cache-aware
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
naymaraq
left a comment
naymaraq
left a comment
There was a problem hiding this comment.
This is really great work. Thanks @lilithgrigoryan
I’ll do another round of review after this one, since I see the PR is still a work in progress.
| self.window_committed_tokens: list[int] = [] | ||
| # Frame timestamps aligned with ``window_committed_tokens``. | ||
| self.window_committed_timestamps: list[int] = [] | ||
|
|
There was a problem hiding this comment.
Since @artbataev recently added a confidence score, should we reflect that here as well?
| prompt_vectors: (Tensor | None) Optional prompt vectors of shape [B, num_prompts]. | ||
| Returns: | ||
| (tuple[list[Hypothesis], CacheAwareContext]) best hypothesis and new context. | ||
| Run the cache-aware encoder for one streaming chunk, returning the (trimmed) |
There was a problem hiding this comment.
For consistency, please bring back the argument descriptions in the docstring.
| options: (ASRRequestOptions) Request options for particular stream. | ||
| Returns: | ||
| (CacheAwareRNNTStreamingState) New empty state. | ||
| (CacheAwareRNNTStreamingState) New empty state. New empty state. |
|
[🤖]: Hi @lilithgrigoryan 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
…/streaming-beam-search-niva-cache-aware
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com>
|
[🤖]: Hi @lilithgrigoryan 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
3 participants
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information