feat(sdk): Add a generic NemoClient#370
Draft
matthewgrossman wants to merge 19 commits into
Draft
Conversation
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Contributor
|
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a typed HTTP client infrastructure to
nemo_platform_pluginthat plugin authors can use to build fully type-safe SDK clients. Endpoints are the single source of truth for the HTTP contract — request type, response type, path parameters, and HTTP method are all declared once and flow through to the client with full type inference.Usage
Key design decisions
NemoClientsubclass, they return typed bound callables via__get__. No wrapper functions needed.NemoClientandAsyncNemoClientsubclasses. The descriptor dispatches the right bound callable.BaseModel(JSON),None(DELETE),BinaryContent(file download/upload),Stream[T](SSE/NDJSON). Overloadedsend()returns the right type.TypedDict+Unpackenforces correct kwargs.workspaceusesNotRequiredso the client default can fill it in.tycan't infer class-level TypeVars from classmethods on generic classes (astral-sh/ty#541). Standaloneget(),post(), etc. infer correctly.NemoPluginSDKResourcesregistration still works viafrom_platform()adapter.Test plan
ty checkpasses on all source files with zero diagnostics🤖 Generated with Claude Code