Refactor and enhance CMIP7 namelist process#287
Open
gold2718 wants to merge 1 commit into
Open
Conversation
- Implement configuration file for usermods sets - Add support for output with COSP and/or Aerocom fields - Add support for separate CAM field request (added to CMIP7 request) - Rewrote README.md file - Add regression test for full output (modify base NHIST test)
gold2718
requested review from
DirkOlivie,
MichaelSchulzMETNO,
Ovewh and
oyvindseland
Ovewh
reviewed
Jun 25, 2026
gold2718
commented
Jun 25, 2026
| missing7 = check_for_missing_fieldnames(all_fieldnames, cmip7_request, | ||
| "CMIP7") | ||
| cam_request = parse_spreadsheet(camfile) | ||
| missingc = check_for_missing_fieldnames(all_fieldnames, cmip7_request, |
Author
There was a problem hiding this comment.
Thanks. I also found that this morning since RESTOM and CO2 were not reported as missing.
Ovewh
reviewed
Jun 25, 2026
| print(f" {field}") | ||
| # end for | ||
| arglist = command_line(sys.argv[1:]) | ||
| cmipfile, camfile, usermods, configfile, overwrite, error, maxline = arglist |
Collaborator
There was a problem hiding this comment.
Suggested change
| cmipfile, camfile, usermods, configfile, overwrite, error, maxline = arglist | |
| cmipfile, camfile, usermods, configfile, overwrite, error, maxline,ignore_fieldlist = arglist |
Ovewh
reviewed
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Refactor and enhance CMIP7 namelist process
Contributors: gold2718
Reviewers: @oyvindseland, @DirkOlivie, @Ovewh, @MichaelSchulzMETNO
Purpose of changes: #286
Github PR URL: #287
Changes made to build system: None
Changes made to the namelist: None except for new usermods options
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None
Detailed description of changes
Testing:
fixes: #286