Issue #1645 Interface Support Mock Testing by kccarter76 · Pull Request #2215 · OData/WebApi

kccarter76 · 2020-07-01T00:14:33Z

Issues

Feature enhancement resolves #1645

Description

added the ability to use an interface IODataQueryOptions as a parameter on a controller method.

Checklist (Uncheck if it is not completed)

Test cases added
Build and test with one-click build and test script passed

Additional work necessary

feature needs to still be documented and the issue #1645 updated with Docs Needed.

While trying to add complex types to the test model for SelectExpandTests, I ran into an issue with EF where some existing tests failed due to EF's own EDM model validation. This was happening because it assumes the new complex type is actually an entity type, even though it doesn't have a key. My solution is just to factor out the EF-related tests into their own class, SelectExpandEFTests. This should allow the addition of complex types to the SelectExpandTests test model without breaking any of the existing tests.

In the spirit of TDD, I wrote a failing test before attempting to fix this issue: OData#196 Unfortunately, the fix looks more like a large and complex feature than just a simple bug fix, and I don't have bandwidth to take it on right now. However, the test may still be useful for the next person to make the attempt.

…ataMember

* Update ODL dependencies to 7.5.0 - Update package versions. - Revert test workaround for the pending 7.5.0 release. - Disable obsolete warnings for AggregateTransformationNode.Expressions introduced in v7.5.0 * Update dependencies on classic side and performance.sln.

…formatter

* Adding support to entity set aggregations.

* Enable IN operator for $filter. Supported collections include paren-defined collections, property collections, and navigation properties. * Added test cases to accompany change.

* downgrade the newtonsoft.json version to 6.0.4 for classic * change the newtonsoft.json version in classic test

kccarter76 · 2020-11-17T20:18:23Z

I do not have write access to the destination branch. the conflicts that are currently listed are a product of natural development and where not present at the time this was completed. I may not have the time available to address.

marabooy

Looks good to me, I didn't find any apparent issues with backwards compatibility.
@kccarter76 Do let me know when you are ready to get this merged in and any help you require.

marabooy · 2020-12-07T09:23:08Z

+    }
+}
+
+namespace Microsoft.AspNet.OData.Test.Formatter.Interface


Split this to two namespaces for consistency.

not sure about what you are asking here? been awhile since looking at this code.

I think you are asking about the sut class version in a class namespace and the interface implementation in an interface namespace. is that correct?

it might be best to split into two separate files to simplify reading the code base.

I need more eyes on this, since I have been unable to resolve the issue with the unit tests not running. @marabooy, I have sent you a collaboration request. I have hit a road block and the work crews appear to be on a permanent coffee break.

…2362) * Enabling query validation EnableQuery before action execution * Adding test * Name updates. * Adding #if for NetCore tests * Adding code to throw BadRequest * Fixing issues * Fixing the public API file * Adding fixes for tests * Fixing generic type code * Adding support for ActionResult<> * Taking PR comments * Taking PR comments * Taking PR comment * Taking PR comments * Just retrying build

…ata#2356)

* Fix MergeIndividualAndBatchPreferences method for same Prefer headers case (bug with an unnecessary comma at the end of line) * Add test merging same Prefer header while processing batch. Co-authored-by: Tsar Nikolay <nsmirnov@ics.perm.ru>

…te files.

kccarter76 · 2021-01-15T05:04:57Z

to resolve the above conflicts, it would be best to collaborate. I am not sure what needs to be kept and merge what is needed to support the interface. EnableQueryAttribute was straight forward. however the others not so much.

…Data#2397) * Moving request query data to HttpContext * Adding one more E2E test * Adding tests for parallelization check

marabooy · 2021-01-15T06:55:00Z

@kccarter76 the BSL updates can be done by running the respective PublicApi tests and copying over the new file.
Checkout the public api test linked here

kccarter76 · 2021-01-15T16:56:16Z

I am missing code for RequestQueryData. I may need to merge/pull the current master into my github fork. okay my EnableQueryAttribute is really out of sync with the base master and when I try to create a pull request from webApi:master to kccarter76webapi:master.

…aster # Conflicts: # src/Microsoft.AspNetCore.OData/EnableQueryAttribute.cs # test/UnitTest/Microsoft.AspNet.OData.Test/PublicApi/Microsoft.AspNet.OData.PublicApi.bsl # test/UnitTest/Microsoft.AspNetCore.OData.Test/PublicApi/Microsoft.AspNetCore.OData.PublicApi.bsl # test/UnitTest/Microsoft.AspNetCore.OData.Test/PublicApi/Microsoft.AspNetCore3x.OData.PublicApi.bsl

kccarter76 · 2021-01-15T18:23:44Z

is this being addressed in the AspNet solution:

Severity Code Description Project File Line Suppression State
Warning CA0507 Post-build Code Analysis (FxCopCmd.exe) has been deprecated in favor of FxCop analyzers, which run during build. Refer to https://aka.ms/fxcopanalyzers to migrate to FxCop analyzers. Active

this exception is preventing me from updating 'Microsoft.AspNet.OData.PublicApi.bsl'

Severity Code Description Project File Line Suppression State
Error CA0001 CA0001 : Exception of type 'Phx.FatalError' was thrown. Active

was able to git this worked around by not running code analysis. however, the x unit tests are not running again and the work around from before is not working.

microsoft/vstest#1220

marabooy · 2021-01-19T07:46:21Z

 	Disabled = 2
 }

+<<<<<<< HEAD


Kindly fix the merge result here. I will check with someone on the team to see what can be done to help.

working on it, currently dealing with an issue where VS 2019 16.8 will not run unit tests on local machine. see tail end of microsoft/vstest#1220

corranrogue9 · 2021-10-23T21:38:02Z

+    /// </summary>
+    [ODataQueryParameterBinding]
+    [NonValidatingParameterBinding]
+    public interface IODataQueryOptions


This is more of a discussion than feedback: I came into this review not really knowing what query options were, and saw that the purpose was to convert it to an interface for mocking. I wondered to myself "how many ways really are there to implement a set of options? won't that just be a data type with a bunch of data type properties? there should just be a constructor overload where anything that needs to be mocked can be set directly instead". Seeing this interface, though, I see the many methods that are useful for the query options. I'm wondering, though, if it makes sense to separate those two things out. In this case, I would think the ApplyTo overloads belong on some other type rather than the options themselves. Do you have any thoughts on this?

BabaDorin · 2021-11-27T11:08:36Z

Any updates?

drmcclelland · 2022-12-09T21:13:13Z

Any updates @kccarter76 ?

biaol-odata and others added 30 commits May 30, 2018 16:26

Issue OData#170 --- Verify SingleResultWithEmptyIQueryable

661d12b

Removing whitespace per PR feedback

bcab6ae

Replacing property with field

3a50dd5

Merge PR#1458: Allow recursive comple3x types in OData model builder

dde1df8

Fix the policheck problem

cff0fd8

add a classic sample project

70096b9

fix the BaseAddressFactory in ODataMediaTypeFormatter

0c8feff

fix issue OData#1471 about the non-odata routing with DataContact & D…

6b36740

…ataMember

Change the OptionalReturn to ReturnNullable in OperationConfiguration

b736b0b

Fix OData#1387: add instance for the select all binder for perf

3357947

Add support for Json Batch.

d02bc61

Return Task<> from method of controller doesn't pick up odata output …

9e447bd

…formatter

Entity set aggregation (OData#906)

c99b321

* Adding support to entity set aggregations.

issue OData#1434: add the OData-Version into the No-Content response

7db0423

move & execute as late as possible

887a7e3

update the version to 7.0 RTM (OData#1512)

1329a7c

[Feature] IN operator in WebAPI (OData#1497)

116e20d

* Enable IN operator for $filter. Supported collections include paren-defined collections, property collections, and navigation properties. * Added test cases to accompany change.

update the version to 7.0.1.beta

70f75f6

downgrade the newtonsoft.json version to 6.0.4 for classic (OData#1519)

4fd6ce5

* downgrade the newtonsoft.json version to 6.0.4 for classic * change the newtonsoft.json version in classic test

Add the optional parameter into the model builder

935602b

change the property and fluent API in parameter configuration

e2c86fc

make covention and attribute routing working on optional parameter

dbc1e62

Modify the public api

5b60d4d

change the variable name

24b50c9

Change the set as protected set in ParameterConfiguration

1082884

Add UseOData() extension methods for IApplicationBuilder

82e801a

Fix issue OData#1529: ETag missing on derived entity set

1e1fe02

Enable case insensitive request binding (OData#2311)

6ff714e

kccarter76 requested a review from marabooy November 17, 2020 20:15

marabooy added this to the 7.5.2 milestone Nov 24, 2020

Fix bug in attribute convention route values (OData#2368)

7e2f7d0

marabooy reviewed Dec 7, 2020

View reviewed changes

RamjotSingh and others added 7 commits December 9, 2020 11:16

Create ODataError in Non-Success responses (OData#2341)

d52c95b

Fix behaviour for Preflight requests on the ODataBatchMiddleware. (OD…

e18111d

…ata#2356)

Fix duplicate batch Cookie header.

122cab1

Update the release version to 7.5.4

4a6ae8f

Update WebStack.versions.settings.targets

129a6a7

kccarter76 requested a review from marabooy January 14, 2021 22:12

seperated the interface and class name space for this sut into sepera…

0198ea4

…te files.

Moving EnableQuery request level query data storage to HttpContext (O…

5a5c585

…Data#2397) * Moving request query data to HttpContext * Adding one more E2E test * Adding tests for parallelization check

kccarter76 added 2 commits January 15, 2021 10:36

resolved conflicts

127a7d9

kccarter76 added 2 commits January 15, 2021 11:26

no message

6567621

resolve conflct

ddffb5d

marabooy requested changes Jan 19, 2021

View reviewed changes

corranrogue9 reviewed Oct 23, 2021

View reviewed changes

xuzhg force-pushed the master branch 2 times, most recently from 4c43a84 to ddfd3dd Compare May 29, 2026 01:09

Uh oh!

Conversation

kccarter76 commented Jul 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Description

Checklist (Uncheck if it is not completed)

Additional work necessary

Uh oh!

kccarter76 commented Nov 17, 2020

Uh oh!

marabooy left a comment

Choose a reason for hiding this comment

Uh oh!

marabooy Dec 7, 2020

Choose a reason for hiding this comment

Uh oh!

kccarter76 Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

kccarter76 Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

kccarter76 Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

kccarter76 Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

kccarter76 commented Jan 15, 2021

Uh oh!

marabooy commented Jan 15, 2021

Uh oh!

kccarter76 commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kccarter76 commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marabooy Jan 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kccarter76 Jan 19, 2021

Choose a reason for hiding this comment

Uh oh!

corranrogue9 Oct 23, 2021

Choose a reason for hiding this comment

Uh oh!

BabaDorin commented Nov 27, 2021

Uh oh!

drmcclelland commented Dec 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

kccarter76 commented Jul 1, 2020 •

edited

Loading

kccarter76 commented Jan 15, 2021 •

edited

Loading

kccarter76 commented Jan 15, 2021 •

edited

Loading

marabooy Jan 19, 2021 •

edited

Loading