PR For Bulk Operation and ODataBind Review for Beta Release by Sreejithpin · Pull Request #2524 · OData/WebApi

Sreejithpin · 2021-07-08T18:23:27Z

Issues

PR For Bulk Operation and ODataBind Review for Beta Release
This pull request fixes issue #xxx.

Description

Briefly describe the changes of this pull request.

Checklist (Uncheck if it is not completed)

Test cases added
Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

* Bulk operations6 (#2) * BulkInsert1 draft * Bulk insert changes * deleted old test * updates * Update ODataResourceSetWrapper.cs * updates * Updated addressing comments * updates * updates updates * Updates * Updates * Minor updates * comments * updates * update publicapi for core * Address comments * Cleanup and additional tests Cleanup and additional tests * Updated code * BulkInsert1 draft * Bulk insert changes * deleted old test * updates * updates * Updated addressing comments * updates * updates updates * Updates * Updates * Minor updates * updates * Address comments * Cleanup and additional tests Cleanup and additional tests * DataAnnotationException updates * comments * small updates * updates * small update * updates * Updates * Update DeltaSetOfT.cs * Updates with Patch * updates * updates * Update WebHostTestFixture.cs * updates * Update DeltaOfTStructuralType.cs * Updates * Updates for serializer etc * Update WebHostTestFixture.cs * updates * updates * updates * Bulk Operations Updates * Review comments addressed * Updates * updated for deltaentity * Update Microsoft.AspNet.OData.Test.csproj * Update Microsoft.AspNet.OData.PublicApi.bsl * update public api * test fix * Update EdmStructuredObject.cs * Update EdmStructuredObject.cs * Update BulkInsertTest.cs * update * public api * review comments * Review comments updates * smalll update * updates * updates * updates

* support for odata.bind * support for odata.bind

xuzhg · 2021-07-14T19:47:12Z

                }
+                else if (ODataRequestMethod.Patch == controllerContext.Request.Method)
+                {
+                    // e.g. Try PatchCustomer first, then fall back to Patch action name


PatchCustomer

PatchCustomers #Resolved

xuzhg · 2021-07-14T19:48:05Z

                    "PostFrom" + entityType.Name);

do we support patch from cast?

PATCH ~/Customers/NS.VipCustomer

Refers to: src/Microsoft.AspNet.OData.Shared/Routing/Conventions/EntitySetRoutingConvention.cs:83 in fbe081a. [](commit_id = fbe081a, deletion_comment = False)

xuzhg · 2021-07-14T19:49:27Z

+using Org.OData.Core.V1;
+using System;
+using System.Collections.Generic;
+using System.Text;


sort #Resolved

xuzhg · 2021-07-14T19:51:03Z

+    /// Helper class for OData Serialization
+    /// </summary>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1053:StaticHolderTypesShouldNotHaveConstructors")]
+    public class ODataSerializerHelper


ODataSerializerHelper

if it's an internal class (I noticed no public API in this class), why don't mark the class as interal, and mark API as public.

In current design, we have a public class, but nothing in the public class from customer perspetive. #Resolved

xuzhg · 2021-07-14T19:56:08Z

-        /// Gets the wrapped <see cref="ODataResource"/>.
+        /// Gets the wrapped <see cref="ODataResource"/>. This will return null for deleted resources.
        /// </summary>
+        [Obsolete("Please use ResourceBase instead")]


[Obsolete("Please use ResourceBase instead")]

This obsolete seems unnecessary.

The idea was to make it obselete but not to remove, right @mikepizzo . but I guess in 8.0 its removed right?

In 8.0 the Resource property should be typed as ODataResourceBase.

Sreejithpin · 2021-07-15T17:01:34Z

                    "PostFrom" + entityType.Name);

Normal Patch (Delta) supports inheritance/casting right?

In reply to: 880162857

Refers to: src/Microsoft.AspNet.OData.Shared/Routing/Conventions/EntitySetRoutingConvention.cs:83 in fbe081a. [](commit_id = fbe081a, deletion_comment = False)

mikepizzo · 2021-07-27T03:31:31Z

+    /// <summary>
+    /// Handler Class to handle users methods for create, delete and update
+    /// </summary>
+    public abstract class EdmPatchMethodHandler


EdmPatchMethodHandler

Since this is not just used for Patch, should we consider renaming to something like "UpdateHandler" or "DataModificationHandler"?

mikepizzo · 2021-07-27T03:34:43Z

+        /// </summary>
+        NotFound
+    }
+


This should be in a separate file #Resolved

mikepizzo · 2021-07-27T03:36:39Z

+    /// <summary>
+    /// Base Interface for PatchMethodHandler
+    /// </summary>
+    public interface IPatchMethodHandler


IPatchMethodHandler

I'm sure I asked this before, but why do we need an empty marker interface? Can you add to the comments so that it's clear to others in the future?

Also, this should be in a separate file so that it is easy to find. #Resolved

mikepizzo · 2021-07-27T03:39:02Z

+
+namespace Microsoft.AspNet.OData
+{    
+    internal class DefaultPatchHandler<TStructuralType> : PatchMethodHandler<TStructuralType> where TStructuralType :class


DefaultPatchHandler

Add comments describing this class, its behavior, and where/when it is appropriate to use. #Resolved

mikepizzo · 2021-07-27T03:40:24Z

+{    
+
+    /// <summary>
+    /// Handler Class to handle users methods for create, delete and update


Handler Class to handle users methods for create, delete and update

Add that this is for the case where there is no CLR type -- PatchMethodHandler is used when there is a clr type. #Resolved

mikepizzo · 2021-07-27T03:41:02Z

+    }
+
+    /// <summary>
+    /// Handler Class to handle users methods for create, delete and update


Handler Class to handle users methods for create, delete and update

add to the description that this is for the clr-backed objects; EdmPatchMethodHandler is used for the non-CLR backed case. #Resolved

mikepizzo · 2021-07-27T03:50:06Z

+namespace Microsoft.AspNet.OData
+{
+    /// <summary>
+    /// Basic interface to reperesent a deltaset which is a collection of Deltas.


Basic interface to reperesent a deltaset which is a collection of Deltas.

Please describe why we have this marker interface with no members. #Resolved

mikepizzo · 2021-07-27T04:02:23Z

+        /// <returns>DeltaSet response</returns>
+        public DeltaSet<TStructuralType> Patch(IPatchMethodHandler patchHandler)
+        {            
+            return CopyChangedValues(patchHandler as PatchMethodHandler<TStructuralType>);


patchHandler as PatchMethodHandler

what happens if this cast fails? #Resolved

* Bulk operations6 (#2) * BulkInsert1 draft * Bulk insert changes * deleted old test * updates * Update ODataResourceSetWrapper.cs * updates * Updated addressing comments * updates * updates updates * Updates * Updates * Minor updates * comments * updates * update publicapi for core * Address comments * Cleanup and additional tests Cleanup and additional tests * Updated code * BulkInsert1 draft * Bulk insert changes * deleted old test * updates * updates * Updated addressing comments * updates * updates updates * Updates * Updates * Minor updates * updates * Address comments * Cleanup and additional tests Cleanup and additional tests * DataAnnotationException updates * comments * small updates * updates * small update * updates * Updates * Update DeltaSetOfT.cs * Updates with Patch * updates * updates * Update WebHostTestFixture.cs * updates * Update DeltaOfTStructuralType.cs * Updates * Updates for serializer etc * Update WebHostTestFixture.cs * updates * updates * updates * Bulk Operations Updates * Review comments addressed * Updates * updated for deltaentity * Update Microsoft.AspNet.OData.Test.csproj * Update Microsoft.AspNet.OData.PublicApi.bsl * update public api * test fix * Update EdmStructuredObject.cs * Update EdmStructuredObject.cs * Update BulkInsertTest.cs * update * public api * review comments * Review comments updates * smalll update * updates * updates * updates

* support for odata.bind * support for odata.bind

…nto BulkOps_Odatabind

pull-request-quantifier-deprecated · 2021-09-07T05:06:51Z

This PR has 7513 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +6890 -623
Percentile : 100%

Total files changed: 1868

Change summary by file extension:
.md : +7 -3
.txt : +2 -1
.yml : +226 -0
.cs : +5975 -426
.csproj : +103 -43
.config : +118 -103
.resx : +18 -0
.projitems : +30 -0
.nuspec : +26 -18
.bsl : +381 -24
.proj : +0 -1
.targets : +4 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detetcted.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

microsoft-github-policy-service · 2026-05-29T01:07:07Z

@Sreejithpin please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ),
and conveys certain license rights to the .NET Foundation ( “.NET Foundation” ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of the latest signature date below.

1. Definitions.

“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.

“Project” means any of the projects owned or managed by .NET Foundation and offered under a license
approved by the Open Source Initiative (www.opensource.org).

“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”

“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

3. Originality of Work. You represent that each of Your Submissions is entirely Your
original work. Should You wish to Submit materials that are not Your original work,
You may Submit them separately to the Project if You (a) retain all copyright and
license information that was in the materials as you received them, (b) in the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third party and any
licenses or other restrictions of which You are aware, and (c) follow any other
instructions in the Project's written guidelines concerning Submissions.

4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

5. Licenses.

a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing
rights to third parties.

b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3 ). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or
circumstances of which You later become aware that would make Your representations in this
Agreement inaccurate in any respect.

8. Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by .NET Foundation.

.NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1.

pull-request-quantifier-deprecated Bot added the Extra Large label Jul 8, 2021

Sreejithpin requested a review from mikepizzo July 8, 2021 18:23

Sreejithpin and others added 3 commits July 8, 2021 11:29

Feature/new add support for odata bind (#2506)

d9ce354

* support for odata.bind * support for odata.bind

updates

fa714f1

Sreejithpin force-pushed the BulkOps_Odatabind branch from 2561d7c to 6ff81ed Compare July 8, 2021 18:51

small update

a52aed5

xuzhg reviewed Jul 14, 2021

View reviewed changes

mikepizzo reviewed Jul 27, 2021

View reviewed changes

Sreejithpin and others added 9 commits July 27, 2021 07:26

Code review comments

9378ff2

update for odataid _temp

b65e403

updates

d9a562d

updates to use only factory

2a6b2bc

updates

1e138f3

Feature/new add support for odata bind (#2506)

934c726

* support for odata.bind * support for odata.bind

updates

13ec941

small update

46a9114

Sreejithpin added 19 commits August 30, 2021 11:56

Code review comments

54b70ee

update for odataid _temp

ae92917

updates

072da71

updates to use only factory

1e89027

updates

f08f13e

Update DeltaOfTStructuralType.cs

b897907

Merge branch 'BulkOps_Odatabind' of https://github.com/OData/WebApi i…

6e43faa

…nto BulkOps_Odatabind

Update DeltaOfTStructuralType.cs

c79efdd

publicapi

97a83f2

test change

3f17c9a

Update Microsoft.AspNetCore.OData.Test.csproj

9bcb6c6

Update Microsoft.Test.E2E.AspNetCore3x.OData.csproj

b317f5f

updates

ba80ebb

Update WebStack.versions.settings.targets

d3c1cb2

Update WebStack.versions.settings.targets

1a3b3a3

Update GetNugetPackageMetadata.proj

3a3e2cb

Update WebStack.versions.settings.targets

4a6bf15

For testing

d4b1e36

update

c431081

Sreejithpin mentioned this pull request Sep 9, 2021

PR For Bulk Operation and ODataBind Review for Beta Release #2567

Open

2 tasks

xuzhg force-pushed the master branch from a12d589 to 4c43a84 Compare May 29, 2026 00:48

xuzhg force-pushed the BulkOps_Odatabind branch from 8bcbd40 to c431081 Compare May 29, 2026 01:05

xuzhg force-pushed the master branch from 4c43a84 to ddfd3dd Compare May 29, 2026 01:09

Uh oh!

Conversation

Sreejithpin commented Jul 8, 2021

Issues

Description

Checklist (Uncheck if it is not completed)

Additional work necessary

Uh oh!

xuzhg Jul 14, 2021 • edited by Sreejithpin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xuzhg commented Jul 14, 2021

Uh oh!

xuzhg Jul 14, 2021 • edited by Sreejithpin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xuzhg Jul 14, 2021 • edited by Sreejithpin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xuzhg Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

Sreejithpin Jul 15, 2021

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jul 27, 2021

Choose a reason for hiding this comment

Uh oh!

Sreejithpin commented Jul 15, 2021

Uh oh!

mikepizzo Jul 27, 2021

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jul 27, 2021 • edited by Sreejithpin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jul 27, 2021 • edited by Sreejithpin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jul 27, 2021 • edited by Sreejithpin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jul 27, 2021 • edited by Sreejithpin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jul 27, 2021 • edited by Sreejithpin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jul 27, 2021 • edited by Sreejithpin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikepizzo Jul 27, 2021 • edited by Sreejithpin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pull-request-quantifier-deprecated Bot commented Sep 7, 2021

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

microsoft-github-policy-service Bot commented May 29, 2026

Contribution License Agreement

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xuzhg Jul 14, 2021 •

edited by Sreejithpin

Loading

xuzhg Jul 14, 2021 •

edited by Sreejithpin

Loading

xuzhg Jul 14, 2021 •

edited by Sreejithpin

Loading

mikepizzo Jul 27, 2021 •

edited by Sreejithpin

Loading

mikepizzo Jul 27, 2021 •

edited by Sreejithpin

Loading

mikepizzo Jul 27, 2021 •

edited by Sreejithpin

Loading

mikepizzo Jul 27, 2021 •

edited by Sreejithpin

Loading

mikepizzo Jul 27, 2021 •

edited by Sreejithpin

Loading

mikepizzo Jul 27, 2021 •

edited by Sreejithpin

Loading

mikepizzo Jul 27, 2021 •

edited by Sreejithpin

Loading