Skip to content

GAST-PTI Documentation + Implementation#420

Open
lukelowry wants to merge 1 commit into
developfrom
lukel/gastpti-dev
Open

GAST-PTI Documentation + Implementation#420
lukelowry wants to merge 1 commit into
developfrom
lukel/gastpti-dev

Conversation

@lukelowry
Copy link
Copy Markdown
Collaborator

@lukelowry lukelowry commented May 29, 2026

Description

Implementation and documentation for the GASTPTI PhasorDynamics governor model.

Proposed changes

  • Added GASTPTI model implementation, documentation, and diagram.
  • Added GASTPTI JSON parsing and SystemModel assembly support.
  • Added focused PhasorDynamicsGovernorGastPtiTest unit coverage.
  • Updated governor registration, input-format docs, and changelog.

Checklist

  • All tests pass (except known PE failure)
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR.

Further comments

The initialization of Pmech in relation to the machine is not ideal and still relies on the machine being initialized first. It makes reading the implementation confusing, in my opinion. I am partial to changing how we initialize models like this (see #405)

@lukelowry lukelowry force-pushed the lukel/gastpti-dev branch 3 times, most recently from 2ed0a56 to be22547 Compare June 1, 2026 05:16
@lukelowry lukelowry requested review from abirchfield and pelesh June 1, 2026 05:20
@lukelowry lukelowry marked this pull request as ready for review June 1, 2026 05:21
@lukelowry lukelowry added this to the WECC Completion milestone Jun 1, 2026
@lukelowry lukelowry force-pushed the lukel/gastpti-dev branch 5 times, most recently from c25a1e8 to 34f2b24 Compare June 5, 2026 18:40
@lukelowry lukelowry force-pushed the lukel/gastpti-dev branch from 34f2b24 to 8c3f488 Compare June 5, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant