ESDC1A Documentation + Implementation#424
Open
lukelowry wants to merge 3 commits into
Open
Conversation
5c12909 to
9000b94
Compare
9000b94 to
7867706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation and documentation for the
ESDC1APhasorDynamics exciter model.Proposed changes
ESDC1Amodel implementation, documentation, and diagram.ESDC1AJSON parsing andSystemModelassembly support.PhasorDynamicsExciterEsdc1aTestunit coverage.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments (A)
@nkoukpaizan, I keep running into an issue with Enzyme for Exciter models in the control voltage effective input algebraic equation:
Enzyme fails if that is an inline expression. Sparsity issue. I am not sure if this is intentional, but I finally found a reliable way to circumvent the issue within the model implementation (the code above).
Further comments (B)
@pelesh @abirchfield @alexander-novo
Out of PR scope, but there is a modeling issue that I'd like to raise here:
GENROU) that we do not currently support:IEEET1, locally computeBus, conditionally included based on consumption (otherwise we could introduce unused nonlinear algebraic equations incessantly!). Same forPlease let me know if I should open distinct issues for these. They are front of mind as I implemented this so I am leaving here for now.