Use system base for governor-machine power signals#438
Open
lukelowry wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use system-base values for governor-machine mechanical power signals.
This is needed because governor ratings are not generally the same as the associated machine MVA base. Governor
pmechsignals, or equivalent governor-machine signals, should therefore specify their power base (Turbine rating in this context). This PR introducesTrateas the TGOV1 component base and converts at the governor signal boundary.Proposed changes
Trateas the TGOV1 component-base parameter.pmechsignal interaction to use system-base values.Tratematches the associated machinemva.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Changelog changes N/A
Further comments
No functional change. This is just a component contract change that I need to establish before I add more complex governors
I made this change as small as possible to fix the TGOV1 issue. Long term a more general base conversion might be prefered but this by no means locks us into a convention.