Skip to content

Support zero IEEET1 transducer time constant#439

Open
lukelowry wants to merge 1 commit into
developfrom
lukel/ieeet1-tr-zero-safety
Open

Support zero IEEET1 transducer time constant#439
lukelowry wants to merge 1 commit into
developfrom
lukel/ieeet1-tr-zero-safety

Conversation

@lukelowry
Copy link
Copy Markdown
Collaborator

Description

Support Tr = 0 in the IEEET1 exciter by treating the sensed terminal voltage state as algebraic when the transducer time constant is zero.

This removes the need for small artificial Tr values in validation and example cases.

Proposed changes

  • Tag IEEET1 Vts as algebraic when Tr = 0.
  • Update the IEEET1 README equations to match the implementation and standard notation
  • Update IEEET1 example, validation, and parser-test data so prior tiny Tr placeholders are zero.
  • Add unit-test for the Tr = 0 algebraic behavior.

Checklist

  • All tests pass for the focused coverage listed below.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Changelog changes N/A

Further comments

Early development known issue that did not matter until detailed validation of the larger models.

@lukelowry lukelowry requested a review from pelesh June 5, 2026 23:17
@lukelowry lukelowry added the enhancement New feature or request label Jun 5, 2026
tag_[6] = false; // y6 - ve - Excit. Cntrl Volt
tag_[7] = false; // y7 - efd - Efd
tag_[8] = false; // y8 - ksat - Saturation
tag_[0] = (Tr_ != 0.0); // y0 - vts - Sensed term volt
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential issues with comparing a floating point value to 0 like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants