Support zero IEEET1 transducer time constant#439
Open
lukelowry wants to merge 1 commit into
Open
Conversation
nkoukpaizan
reviewed
Jun 6, 2026
| tag_[6] = false; // y6 - ve - Excit. Cntrl Volt | ||
| tag_[7] = false; // y7 - efd - Efd | ||
| tag_[8] = false; // y8 - ksat - Saturation | ||
| tag_[0] = (Tr_ != 0.0); // y0 - vts - Sensed term volt |
Collaborator
There was a problem hiding this comment.
There are potential issues with comparing a floating point value to 0 like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support
Tr = 0in the IEEET1 exciter by treating the sensed terminal voltage state as algebraic when the transducer time constant is zero.This removes the need for small artificial
Trvalues in validation and example cases.Proposed changes
Vtsas algebraic whenTr = 0.Trplaceholders are zero.Tr = 0algebraic behavior.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Changelog changes N/A
Further comments
Early development known issue that did not matter until detailed validation of the larger models.