Skip to content

Add HyKKT Solver Class#432

Merged
andrewxu319 merged 108 commits into
andrew/sccg-and-matrix-classfrom
andrew/hykkt-solver
Jun 4, 2026
Merged

Add HyKKT Solver Class#432
andrewxu319 merged 108 commits into
andrew/sccg-and-matrix-classfrom
andrew/hykkt-solver

Conversation

@andrewxu319
Copy link
Copy Markdown
Collaborator

@andrewxu319 andrewxu319 commented Jun 4, 2026

Description

Added class HyKKTSolver, which integrates components in resolve/hykkt to solve HyKKT systems.

Proposed changes

matrix handler, vector

  • Created HyKKT solver class
  • Created corresponding unit tests and test matrices
  • Added helper functions in Sparse and VectorHandler required by the HyKKT solver
  • Rewrote memory copy code in the CPU implementations Cholesky and SpGEMM to avoid memory corruption issues
  • Modified io.cpp to add safeguards against inputs of empty matrices and unlabeled symmetric matrices

Checklist

  • All tests pass (make test and make test_install per testing instructions). Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • I have manually run the non-experimental examples and verified that residuals are close to machine precision. (In your build directory run: ./examples/<your_example>.exe -h to get instructions how to run examples). Code tested on:
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows Re::Solve style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

pelesh and others added 30 commits June 4, 2026 09:55
@pelesh @shakedregev
Fix make test_install failure (#428)
3dc20a9 
* Fix make test_install failure

* Apply pre-commmit fixes

* Apply suggestion from @shakedregev

---------

Co-authored-by: pelesh <pelesh@users.noreply.github.com>
Co-authored-by: Shaked Regev <35384901+shakedregev@users.noreply.github.com>
@shakedregev
Made spack test more robust (#433)
6614574 
* made spack test more robust

* changelog update [skip ci]
@andrewxu319
Create Matrix class, a parent class for matrices including Sparse
a58c272
@andrewxu319
Added CPU implementation for Schur Complement Conjugate Gradient and …
6facfbf 
…a simple test.
@andrewxu319
Fixed bug in MatrixHandlerTests.hpp that caused leftScale and rightSc…
222f531 
…ale tests to fail. Made "createIncrementingVector()" return a pointer to the new vector instead of a copy (which causes the data to be freed prematurely).
@andrewxu319
Add to CHANGELOG.md. Removed some unnecessary comments.
a56fed8
@andrewxu319
Bug fixes (missing <cmath>, type mismatch of variable "i").
b255e05
@andrewxu319
Revert "Create Matrix class, a parent class for matrices including Sp…
98e9fa0 
…arse"

This reverts commit 00f6992.

Kept changes to "io.cpp", which fixes the an issue with out-of-bounds iterators.
@andrewxu319
Apply pre-commmit fixes
7ea2003
@shakedregev @andrewxu319
Update tests/unit/hykkt/HykktSCCGTests.hpp
9257d39 
No commented out code.
@andrewxu319
Formatting fixes.
70690f5
@andrewxu319
Apply pre-commmit fixes
8e63330
@andrewxu319
Removed "Matrix.hpp" from resolve/matrix/CMakeLists.txt
8bb763a
@andrewxu319
Apply pre-commmit fixes
6614b2d
@shakedregev @andrewxu319
Apply suggestion from @shakedregev
401ab8d
@shakedregev @andrewxu319
fixed not building test, test still fails on HIP
e8271e7
@tamar-dewilde @andrewxu319
use caller-provided backend-specific handlers in SCCG
abe0001
@tamar-dewilde @andrewxu319
load SCCG data on host before device sync
3f41fd9
@tamar-dewilde @andrewxu319
refresh CUDA SpMV cache when matrix changes
2ed38d4
@tamar-dewilde @andrewxu319
Apply pre-commmit fixes
34b60fa
@tamar-dewilde @andrewxu319
fix HyKKT SCCG HIP target setup
a3a641d
@tamar-dewilde @andrewxu319
document SCCG backend setup and CUDA SpMV cache handling
c91d1e9
@tamar-dewilde @andrewxu319
mirror SpMV cache reset for HIP
432a3fc
@tamar-dewilde @andrewxu319
clean up build warnings
edba619
@tamar-dewilde @andrewxu319
update variable names to follow conventions
a06f578
@tamar-dewilde @andrewxu319
Apply pre-commmit fixes
fc1ad61
@shakedregev @andrewxu319
Shaked/random error fix (#424)
d509b5a 
Fixed stochastic failures due to a faulty random number generator and asynchronous operations.

Co-authored-by: shakedregev <shakedregev@users.noreply.github.com>
@andrewxu319
Begin work on porting the HyKKT solver from https://github.com/ORNL/h…
501d93e 
…ykkt/. Code compiles but has not been tested.

Co-authored-by: andrewxu319 <andrewxu319@users.noreply.github.com>
@andrewxu319
Consolidated the setters for matrix and vector blocks of the system.
aeb77c8
@andrewxu319
Add unit tests for HyKKT solver
f82a989
andrewxu319 and others added 22 commits June 4, 2026 21:06
@andrewxu319
Pass handlers by pointer. This is more consistent with the rest of th…
fbe3cb9 
…e codebase.
@andrewxu319
Formatting fixes as suggested in PR.
add3604
@andrewxu319
Apply pre-commmit fixes
d386be0
@andrewxu319
Reordered variable declaration in SCCG to avoid [-Wreorder] warning
eb24d94
@andrewxu319
SCCG test no longer needs a random number generator
f552115
@andrewxu319
Apply pre-commmit fixes
00312e6
@shakedregev @andrewxu319
Apply suggestion from @shakedregev
a4d69d6
@shakedregev @andrewxu319
Apply pre-commmit fixes
51cd4c1
@shakedregev @andrewxu319
Apply suggestion from @shakedregev
34edc96
@andrewxu319 @shakedregev
Update resolve/hykkt/spgemm/SpGEMMCpu.cpp
dbfd1c4 
Co-authored-by: Shaked Regev <35384901+shakedregev@users.noreply.github.com>
@andrewxu319
Apply pre-commmit fixes
01146e6
@shakedregev @andrewxu319
Apply suggestion from @shakedregev
fef6f6a
@andrewxu319
Change HyKKTSolver and SCCG variable naming conventions to use the Hy…
24b8853 
…KKT paper's variable names in LaTeX syntax
@andrewxu319
Add missing scal function for HIP and remove redundant diag_end param…
ddd0e26 
…eter
@andrewxu319
Apply pre-commmit fixes
c435ac2
@andrewxu319
Remove unused memory handler in SpGEMMCpu.hpp
10a3720
@andrewxu319
Change index integer type to avoid type mismatch warnings
c337eae
@andrewxu319
Remove unused variables and revert accidental CMakePresets changes
6df237e
@andrewxu319
Merge branch 'andrew/hykkt-solver' of https://github.com/ORNL/ReSolve …
d8bc515 
…into andrew/hykkt-solver
@andrewxu319
Update CMakeLists.txt because the recent additions were reverted somehow
4de9634
@andrewxu319
Merge commit '6614574876337a4a6c886b624ca0017fe836f188' into andrew/h…
4a61c1c 
…ykkt-solver
@andrewxu319
Merge branch 'andrew/sccg-and-matrix-class' into andrew/hykkt-solver
3bb629c
@pelesh pelesh self-requested a review June 4, 2026 21:40
@pelesh pelesh added enhancement New feature or request hip cuda labels Jun 4, 2026
@pelesh pelesh added this to the HyKKT milestone Jun 4, 2026
@andrewxu319 andrewxu319 merged commit 6a1eeef into andrew/sccg-and-matrix-class Jun 4, 2026
6 checks passed
@andrewxu319 andrewxu319 deleted the andrew/hykkt-solver branch June 4, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shakedregev shakedregev shakedregev left review comments

@pelesh pelesh Awaiting requested review from pelesh

Assignees

@andrewxu319 andrewxu319

Labels

cuda enhancement New feature or request hip

Projects

None yet

Milestone

HyKKT

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewxu319 @shakedregev @pelesh @tamar-dewilde