fix(redis): default sentinel ports per address#4697
Open
haoshengzhen wants to merge 1 commit into
Open
Conversation
Signed-off-by: haoshengzhen <haoshengzhen@outlook.com>
Author
|
@bragaigor Hi, Could you please review this PR at your convenience? Thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When parsing
redis+sentinelURLs with multiple sentinel addresses, an address without an explicit port used the full URL host list as its host fallback. For example:redis+sentinel://sentinel-1,sentinel-2:26379/mastercould produce an invalid first address instead of defaulting only
sentinel-1to port6379.This change applies the missing-port fallback per sentinel address, preserving explicitly configured ports on the other addresses. It also adds a regression test and a changelog fragment.
Testing
gofmtgit diff --checksentinel-1:6379andsentinel-2:26379.