Drain pending Gloas data columns for our own proposed block#17059
Open
potuz wants to merge 5 commits into
Open
Drain pending Gloas data columns for our own proposed block#17059potuz wants to merge 5 commits into
potuz wants to merge 5 commits into
Conversation
potuz
force-pushed
the
receive-self-columns
branch
from
61a99e7 to
f2294bb
Compare
Our own proposed block is imported via the RPC path (ProposeBeaconBlock -> ReceiveBlock) and never re-enters the gossip/by-root ingest paths that drain pending Gloas columns. Columns peers reconstruct and gossip back to us arrive before our local import, get queued as "block not yet seen", and are never drained -- so the payload's data columns are declared unavailable at slot end. Subscribe sync to the statefeed BlockProcessed event (which fires on every import path, including our own block) and drain the pending Gloas columns for the processed root. Gated on regular sync to avoid needless work on the initial-sync batch path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
potuz
force-pushed
the
receive-self-columns
branch
from
f2294bb to
1338ba3
Compare
james-prysm
previously approved these changes
Jun 30, 2026
| if s.cfg.initialSync != nil && s.cfg.initialSync.Syncing() { | ||
| continue | ||
| } | ||
| s.processPendingGloasColumns(s.ctx, data.BlockRoot, data.SignedBlock) |
Collaborator
There was a problem hiding this comment.
Use a go routine here? (we do in other places as well)
reason being state feed send blocks until it drains (its size is 1), if this takes longer, I dont know what other things this may be blocking
terencechain
approved these changes
Jun 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
syjn99
approved these changes
Jul 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our own proposed block is imported via the RPC path (ProposeBeaconBlock -> ReceiveBlock) and never re-enters the gossip/by-root ingest paths that drain pending Gloas columns. Columns peers reconstruct and gossip back to us arrive before our local import, get queued as "block not yet seen", and are never drained -- so the payload's data columns are declared unavailable at slot end.
Subscribe sync to the statefeed BlockProcessed event (which fires on every import path, including our own block) and drain the pending Gloas columns for the processed root. Gated on regular sync to avoid needless work on the initial-sync batch path.