Skip to content

ci: allow comment step to run after validation error #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fionnachan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: allow comment step to run after validation error #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/validate-delegate-registration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ jobs:

- name: Validate submission
id: validate
# Don't fail the job here — the next step needs to run on
# validation failure to post a comment. We re-fail the job
# explicitly at the end if outcome is 'failure'.
continue-on-error: true
env:
# Only inject the RPC secret on the privileged manual-dispatch
# trigger. Auto-validation runs (issue events) fall back to the
Expand All @@ -128,7 +132,7 @@ jobs:
run: pnpm exec tsx scripts/validate-delegate-registration.ts submission.json 2>&1 | tee validation-output.txt

- name: Comment on issue with validation errors
if: failure() && steps.validate.outcome == 'failure'
if: steps.validate.outcome == 'failure'
uses: actions/github-script@v9
env:
DISPATCH_ISSUE_NUMBER: ${{ inputs.issue_number }}
Expand Down Expand Up @@ -181,3 +185,9 @@ jobs:
issue_number: issueNumber,
body,
});

- name: Fail the job if validation failed
if: steps.validate.outcome == 'failure'
run: |
echo "Delegate registration validation failed; see prior step output."
exit 1
Loading