Stabilise Queue test cleanup and normalise documentation markers#1700
Open
peter-lawrey wants to merge 7 commits into
Open
Stabilise Queue test cleanup and normalise documentation markers#1700peter-lawrey wants to merge 7 commits into
peter-lawrey wants to merge 7 commits into
Conversation
|
sam-ross
approved these changes
Mar 10, 2026
9df3e9d to
53c4abd
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR improves Chronicle Queue test stability by centralising background resource cleanup and making queue directory deletion more reliable, especially around mapped file handles and Windows cleanup behaviour.
It also tidies the documentation by replacing non-ASCII punctuation and star-based Enterprise markers with clearer plain-text wording.
Changes
Add shared
QueueTestCommon.drainBackgroundCleanup()helper to:Add
QueueTestCommon.deleteDirAfterCleanup(...)for safer test directory deletion after mapped-file cleanup.Replace repeated direct calls to
BackgroundResourceReleaser.releasePendingResources()across tests with the shared cleanup helper.Make tests more robust when deleting queue files or directories after appender/tailer activity.
Improve
AppenderFileHandleLeakTestby:preAfter().Add a
TableStoreWriteLockTestcase to verify a subprocess can acquire the table-store write lock before timeout.Update tests that now need expected-exception handling to extend
QueueTestCommon.Avoid resetting the security manager on Java 17+.
Normalise documentation and examples by:
★Enterprise markers with(Enterprise);.cq4sample output with[binary cq4 bytes omitted];Risk
Low. The production code changes are limited to documentation/Javadoc wording. The behavioural changes are test-side cleanup and stability improvements.