Removed various duplicate tests.#1238
Merged
Merged
Conversation
- Move robertson_problem ExplicitShooting/LSODA test to test/ (unique stiff ODE handling) - Move cannonball boundary_balance/implicit duration test to test/ (unique pattern) - Move length_constrained_brachistochrone arc length constraint test to test/ (unique constraint pattern) - Remove 12 redundant doc tests that duplicate notebook examples and existing test/ coverage All tests verified to pass. Reduces maintenance burden and CI time.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Coverage is 0.0% — robfalck:remove_duplicate_tests_clean into OpenMDAO:master. No base build found for |
dingraha
approved these changes
May 13, 2026
dingraha
left a comment
dingraha
left a comment
There was a problem hiding this comment.
Looks good to me. So the tests that were removed (eg the examples/brachistochrone/docs/test_* stuff) are redundant versions of examples/brachistochrone/test, right?
Contributor
Author
Yes, between that and the documentation ipynb files, they were duplicates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move unique doc tests to test directories and remove redundant doc tests
Related Issues
Backwards incompatibilities
None
New Dependencies
None