Skip to content

[com1]: restrict entrainable deposition checks to specific modules#1318

Merged
fso42 merged 1 commit into
masterfrom
fixCom9Entrainable
Jul 14, 2026
Merged

[com1]: restrict entrainable deposition checks to specific modules#1318
fso42 merged 1 commit into
masterfrom
fixCom9Entrainable

Conversation

@fso42

@fso42 fso42 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
  • Updated logic to apply entrainable deposition validation only for com1DFA, com5SnowSlide, and com6RockAvalanche.

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

- Updated logic to apply entrainable deposition validation only for `com1DFA`, `com5SnowSlide`, and `com6RockAvalanche`.
@fso42
fso42 requested review from Michael-Pallua and PaulaSp3 July 14, 2026 08:12
@fso42 fso42 self-assigned this Jul 14, 2026
@fso42 fso42 added the bugfix label Jul 14, 2026
@qltysh

qltysh Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

All good ✅

Comment thread avaframe/com1DFA/com1DFA.py
@qltysh

qltysh Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA62.5%

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py62.5%3521-3523
Total62.5%
🤖 Increase coverage with AI coding...
In the `fixCom9Entrainable` branch, add test coverage for this new code:

- `avaframe/com1DFA/com1DFA.py` -- Line 3521-3523

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@fso42 fso42 changed the title fix(com1DFA): restrict entrainable deposition checks to specific modules [com1]: restrict entrainable deposition checks to specific modules Jul 14, 2026
@fso42
fso42 merged commit be3687e into master Jul 14, 2026
5 of 11 checks passed
@fso42
fso42 deleted the fixCom9Entrainable branch July 14, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants