Add mesh name assignment to prim if available in inner_instance_list#173
Open
KanikaBreed wants to merge 1 commit into
Open
Add mesh name assignment to prim if available in inner_instance_list#173KanikaBreed wants to merge 1 commit into
KanikaBreed wants to merge 1 commit into
Conversation
This brings Avastar mesh uploads closer to Second Life behavior by allowing individual mesh parts to retain their intended names instead of always being assigned generated off of the root mesh name.
There was a problem hiding this comment.
Pull request overview
Updates the mesh upload CAPS handling to better match Second Life behavior by allowing individual mesh parts (instances) to set the resulting SceneObjectPart name from the per-instance "mesh_name" field when present, instead of always deriving names from the root asset name.
Changes:
- Assign
prim.Namefrominner_instance_list["mesh_name"]when available and non-empty. - Preserve the existing fallback naming scheme (
assetNamefor root,assetName#<i>for children) when no per-part name is provided.
Comment on lines
+953
to
958
| if (inner_instance_list.ContainsKey("mesh_name") && !string.IsNullOrEmpty(inner_instance_list["mesh_name"].AsString())) | ||
| prim.Name = inner_instance_list["mesh_name"].AsString(); | ||
| else if (grp == null) | ||
| prim.Name = assetName; | ||
| else | ||
| prim.Name = assetName + "#" + i.ToString(); |
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings Avastar mesh uploads closer to Second Life behavior by allowing individual mesh parts to retain their intended names instead of always being assigned generated off of the root mesh name.