Skip to content

Fix 0.19.0 iOS binary package usage#931

Merged
Kyle-Ye merged 1 commit into
mainfrom
bugfix/release_compute
Jul 7, 2026
Merged

Fix 0.19.0 iOS binary package usage#931
Kyle-Ye merged 1 commit into
mainfrom
bugfix/release_compute

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary

Fixes a 0.19.0 iOS binary package usage issue where downstream apps could fail to import OpenSwiftUI from the prebuilt XCFramework.

The UIKit geometry hook remains implemented, but is now hidden from the public Swift interface with SPI.

Root Cause

The iOS simulator XCFramework public .swiftinterface exposed _UIHostingView._geometryChanged(_:forAncestor:) as an open UIKit override. Downstream consumers validated that declaration against UIKit's public module interface, where this selector is not declared, so importing OpenSwiftUI could fail before the app target built.

Keeping the override open is still required for the implementation to compile, so this change marks it as SPI instead of lowering the access level.

@github-actions github-actions Bot added area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. platform: iOS iOS-specific behavior or support. type: bug Something is not working correctly. labels Jul 7, 2026
@Kyle-Ye Kyle-Ye marked this pull request as ready for review July 7, 2026 15:52
@Kyle-Ye Kyle-Ye merged commit 46a26cd into main Jul 7, 2026
7 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/release_compute branch July 7, 2026 15:52
@augmentcode

augmentcode Bot commented Jul 7, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Hides _UIHostingView._geometryChanged(_:forAncestor:) from the public Swift interface by marking the override as SPI.

Why: Avoids downstream import failures when validating the prebuilt iOS simulator XCFramework’s .swiftinterface against UIKit, while keeping the required open override for compilation.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.93%. Comparing base (859ce24) to head (5111170).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   25.92%   25.93%           
=======================================
  Files         720      720           
  Lines       50774    50774           
=======================================
+ Hits        13163    13166    +3     
+ Misses      37611    37608    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. platform: iOS iOS-specific behavior or support. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant