SESSION-1: register in-flight session fields; move site_id ownership to BRIDGE-1#64
Draft
JarbasAl wants to merge 1 commit into
Draft
SESSION-1: register in-flight session fields; move site_id ownership to BRIDGE-1#64JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0bfeabc to
cd63677
Compare
dc008c2 to
6b3d639
Compare
6b3d639 to
f47556d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the SESSION-1
§2.1field-registry edits that were previously bundled as companion edits inside the CONVERSE-1 (#25), FALLBACK-1 (#39), PERSONA-1 (#37), USER-ID-1 (#54) and BRIDGE-1 (#43) feature PRs into a single one-file change to the spec they all amend — per the 1 file, 1 PR rule.Changes (ovos-session-1.md)
converse_handlers(CONVERSE-1 §2.1),fallback_handlers(FALLBACK-1 §4),persona_id(PERSONA-1 §3), the identity fieldsuser_id/voice_id/face_id/name_id/passphrase_id/default_user_id(USER-ID-1 §2) andauth_level(integer, USER-ID-1 §3).site_id— move the full definition to OVOS-BRIDGE-1 §3.4; this section and the registry Owner column become pointers, retaining only the orchestrator-pipeline consumer constraints (opaque, no-overwrite).active_handlers→ PIPELINE-1 §7.1,converse_handlers→ CONVERSE-1 §2.1; add owners for the new fields.Compatibility: V1 (backwards-compatible) — every field is OPTIONAL on the wire; a V0/V1 consumer that ignores the new fields is unaffected.
The feature PRs listed above will drop their SESSION-1 edits and forward-reference this PR.