Skip to content

PIPELINE-1: required_slots backstop, reserve fallback/common_query, listen field#66

Draft
JarbasAl wants to merge 1 commit into
devfrom
spec/pipeline1-plugin-companions
Draft

PIPELINE-1: required_slots backstop, reserve fallback/common_query, listen field#66
JarbasAl wants to merge 1 commit into
devfrom
spec/pipeline1-plugin-companions

Conversation

@JarbasAl

Copy link
Copy Markdown
Member

Consolidates the ovos-pipeline-1.md companion edits previously bundled into the union-slots (#56), FALLBACK-1 (#39), COMMON-QUERY-1 (#40) and AUDIO-1 (#38) feature PRs into a single one-file change — per the 1 file, 1 PR rule.

Changes

  • §6.1 / §6.2 — orchestrator backstop for required_slots (INTENT-3 §5.3): after a plugin returns a Match, the orchestrator MUST treat it as declined if any required slot is absent. Second line of defense behind engine-side match() enforcement.
  • §7.3 — reserve two further intent_names: fallback (FALLBACK-1 §6.3) and common_query (COMMON-QUERY-1 §3). COMMON-QUERY-1 asserted the reservation but never added the registry row — this closes that gap.
  • §9.6 — add the OPTIONAL listen field to ovos.utterance.speak; the output-side behaviour is owned by AUDIO-1.

Compatibility: all additions are backwards-compatible. PIPELINE-1 is already V2 (its namespaced topics replace pre-spec names); these refinements don't change the class, so Version stays 2.

#56 / #39 / #40 / #38 drop their pipeline-1 companion edits and forward-reference this PR.

@JarbasAl JarbasAl force-pushed the spec/pipeline1-plugin-companions branch from 1204568 to d47ed79 Compare June 22, 2026 17:23
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3ba9b7a2-d910-4e53-a06e-4383145ef937

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/pipeline1-plugin-companions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl JarbasAl force-pushed the spec/pipeline1-plugin-companions branch from d47ed79 to 303b7f3 Compare June 22, 2026 17:29
@JarbasAl JarbasAl force-pushed the spec/pipeline1-plugin-companions branch from 303b7f3 to 2c42e43 Compare June 23, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant