Skip to content

feat: session-aware game-skill + OCP playback#428

Draft
JarbasAl wants to merge 1 commit into
devfrom
feat/gameskill-and-ocp-deprecation
Draft

feat: session-aware game-skill + OCP playback#428
JarbasAl wants to merge 1 commit into
devfrom
feat/gameskill-and-ocp-deprecation

Conversation

@JarbasAl

Copy link
Copy Markdown
Member

Split out from #427. Stacked on #427 (feat/intent-layers-context) — merge that first.

488 tests pass locally.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8935b831-0783-4dd4-8629-5fcf2a1f67a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/gameskill-and-ocp-deprecation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl JarbasAl force-pushed the feat/gameskill-and-ocp-deprecation branch from 64c35d7 to f776228 Compare June 26, 2026 01:38
@JarbasAl JarbasAl changed the base branch from feat/intent-layers-context to dev June 26, 2026 02:32
@github-actions github-actions Bot added feature and removed feature labels Jun 26, 2026
@JarbasAl JarbasAl force-pushed the feat/gameskill-and-ocp-deprecation branch from f776228 to 7473e2d Compare June 26, 2026 02:37
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Hey! I've got some fresh data on your pull request. 📈

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

I've gathered the facts for your review. 📖

ruff: issues found — see job log

📋 Repo Health

I've checked the repo's posture (aka architectural alignment). 🧘

✅ All required files present.

Latest Version: 9.2.0a1

ovos_workshop/version.py — Version file
README.md — README
LICENSE — License file
pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
CHANGELOG.md — Changelog
ovos_workshop/version.py has valid version block markers

⚖️ License Check

Ensuring no copyleft violations in this PR. ⬅️

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔒 Security (pip-audit)

Ensuring no malicious actors are hitching a ride. 🎭

✅ No known vulnerabilities found (73 packages scanned).

🔨 Build Tests

Ensuring no loose screws in the assembly. 🔩

Python Build Install Tests
3.10 ⚠️
3.11 ⚠️
3.12 ⚠️
3.13 ⚠️
3.14 ⚠️

❌ 3.10: Install OK, tests failed
❌ 3.11: Install OK, tests failed
❌ 3.12: Install OK, tests failed
❌ 3.13: Install OK, tests failed
❌ 3.14: Install OK, tests failed
Check job logs for details.


The silent guardian of the dev branch. 🦇

@JarbasAl JarbasAl marked this pull request as draft June 27, 2026 15:48
Per-session playback state in OVOSCommonPlaybackSkill (state events emit via
message.reply so they route to the originating session) and game_skill on the
context-gated layers (probing skill_will_match with its session). OCPCommonPlayback
deprecation is handled in #423.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@JarbasAl JarbasAl force-pushed the feat/gameskill-and-ocp-deprecation branch from 7473e2d to a359cc9 Compare July 3, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant