fix: don't double-emit ovos.utterance.handled from fallback/converse when core owns it#453
Merged
JarbasAl merged 1 commit intoJul 3, 2026
Conversation
…se when core owns it The matched-intent path already guards its ovos.utterance.handled emission on _core_owns_utterance_handled() (PIPELINE-1 §9.5 — ovos-core >=2.3.0a1 owns the universal end-marker on every terminal path). The FallbackSkill and ConversationalSkill terminal paths still emitted it unconditionally, so against a core that owns it the end-marker fired twice (skill + orchestrator). Guard both on the same version check so exactly one ovos.utterance.handled terminates the utterance; keep emitting for an older/absent core during the migration window. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The matched-intent path already guards its
ovos.utterance.handledemission on_core_owns_utterance_handled()(PIPELINE-1 §9.5 — ovos-core >=2.3.0a1 owns theuniversal end-marker on every terminal path).
FallbackSkillandConversationalSkillstill emitted it unconditionally, so against a core thatowns it the end-marker fired twice (skill + orchestrator). This guards both
on the same version check.
Why
Surfaced by
ovos-test-harnessconformance suites against the spec-adoptionstack:
test_fallback1 TestSec6QueryResponse.test_exactly_one_handled,test_converse1 TestSec4ConverseRoundTrip.test_followup_terminates_once, andtest_common_query1 TestSec9NoWinnerReachesFallback.test_non_question_terminates_onceeach saw 2 end-markers instead of 1.
Stacked on
feat/intent-4-producer(#431) so the harness combo can pin oneworkshop branch carrying both the INTENT-4 producer and this fix.
🤖 Generated with Claude Code