Skip to content

feat: emit OVOS-INTENT-2 §4.3 entity/slot blacklist on registration#454

Merged
JarbasAl merged 1 commit into
devfrom
feat/entity-blacklist
Jul 3, 2026
Merged

feat: emit OVOS-INTENT-2 §4.3 entity/slot blacklist on registration#454
JarbasAl merged 1 commit into
devfrom
feat/entity-blacklist

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Jul 3, 2026

Copy link
Copy Markdown
Member

Implements OVOS-INTENT-2 §4.3 entity .blacklist (architecture#104) — a slot-value exclusion list paired by base name with an .entity/{slot} — so intent engines can drop blacklisted slot values (e.g. a person.blacklist of pronouns keeps "he" out of {person}, leaving the slot unresolved for a later CONTEXT-1 §7 fill or re-prompt).

Mirrors the already-merged <intent>.blacklist suppression loading, extending it to entities and slots.

Changes

  • register_entity_file loads the sibling <entity>.blacklist and passes it to register_padatious_entity, which emits it as a blacklist field on the padatious:register_entity payload.
  • register_intent_file scans every {slot} the template declares, loads each sibling <slot>.blacklist, and passes a {slot: [phrases]} map to register_padatious_intent, emitted as slot_blacklist on the padatious:register_intent payload.
  • Both fields are additive and default empty ([] / {}), so the payload shape stays stable and backward compatible. A missing .blacklist yields an empty result (no error).

Tests

New TestSlotBlacklistFile in test_skill.py plus fixtures (person.entity+person.blacklist with he/she, thing.blacklist): entity registers with the blacklist phrases; intent registers with per-slot exclusions keyed by slot; absent files give empty (back-compat). Existing exact-signature assertions in test_base.py / test_intent_service_interface.py updated for the new kwargs.

🤖 Generated with Claude Code

Load the sibling `<entity>.blacklist` / `<slot>.blacklist` locale files and
carry their slot-value exclusions in the registration payloads so intent
engines can drop blacklisted slot values (e.g. a `person.blacklist` of pronouns
keeps "he" out of `{person}`).

- register_entity_file loads `<entity>.blacklist` and emits it as `blacklist`
  on the `padatious:register_entity` payload.
- register_intent_file scans each `{slot}` the template declares, loads the
  sibling `<slot>.blacklist`, and emits `slot_blacklist` keyed by slot name on
  the `padatious:register_intent` payload.

Both fields default empty (list / dict), keeping the payload shape-stable and
backward compatible. Mirrors the existing `<intent>.blacklist` suppression.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d3ad60e5-a0a8-45c7-87b5-a5f11fa09db5

📥 Commits

Reviewing files that changed from the base of the PR and between ff771d4 and bcd5e24.

📒 Files selected for processing (8)
  • ovos_workshop/intents.py
  • ovos_workshop/skills/ovos.py
  • test/unittests/ovos_tskill_blacklist/locale/en-US/person.blacklist
  • test/unittests/ovos_tskill_blacklist/locale/en-US/person.entity
  • test/unittests/ovos_tskill_blacklist/locale/en-US/thing.blacklist
  • test/unittests/skills/test_base.py
  • test/unittests/test_intent_service_interface.py
  • test/unittests/test_skill.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/entity-blacklist

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

I've scrutinized every line of your PR. Here's the report. 🧐

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

Just keeping you informed on the state of things. ℹ️

ruff: issues found — see job log

🔒 Security (pip-audit)

I've scanned the dependencies for any hidden surprises. 🔍

✅ No known vulnerabilities found (73 packages scanned).

📋 Repo Health

Scanning for any signs of repository fatigue. 😫

✅ All required files present.

Latest Version: 9.1.0a1

ovos_workshop/version.py — Version file
README.md — README
LICENSE — License file
pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
CHANGELOG.md — Changelog
ovos_workshop/version.py has valid version block markers

⚖️ License Check

I've checked for any 'all rights reserved' surprises. 🛑

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔨 Build Tests

Checking if all the bolts are tightened. 🔩

✅ All versions pass

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

Built by scripts, maintained by community 🤝

@JarbasAl JarbasAl marked this pull request as ready for review July 3, 2026 18:07
@JarbasAl JarbasAl merged commit 2a9bfbf into dev Jul 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant