feat: emit OVOS-INTENT-2 §4.3 entity/slot blacklist on registration#454
Conversation
Load the sibling `<entity>.blacklist` / `<slot>.blacklist` locale files and
carry their slot-value exclusions in the registration payloads so intent
engines can drop blacklisted slot values (e.g. a `person.blacklist` of pronouns
keeps "he" out of `{person}`).
- register_entity_file loads `<entity>.blacklist` and emits it as `blacklist`
on the `padatious:register_entity` payload.
- register_intent_file scans each `{slot}` the template declares, loads the
sibling `<slot>.blacklist`, and emits `slot_blacklist` keyed by slot name on
the `padatious:register_intent` payload.
Both fields default empty (list / dict), keeping the payload shape-stable and
backward compatible. Mirrors the existing `<intent>.blacklist` suppression.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
I've scrutinized every line of your PR. Here's the report. 🧐I've aggregated the results of the automated checks for this PR below. 🔍 LintJust keeping you informed on the state of things. ℹ️ ❌ ruff: issues found — see job log 🔒 Security (pip-audit)I've scanned the dependencies for any hidden surprises. 🔍 ✅ No known vulnerabilities found (73 packages scanned). 📋 Repo HealthScanning for any signs of repository fatigue. 😫 ✅ All required files present. Latest Version: ✅ ⚖️ License CheckI've checked for any 'all rights reserved' surprises. 🛑 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔨 Build TestsChecking if all the bolts are tightened. 🔩 ✅ All versions pass
Built by scripts, maintained by community 🤝 |
Implements OVOS-INTENT-2 §4.3 entity
.blacklist(architecture#104) — a slot-value exclusion list paired by base name with an.entity/{slot}— so intent engines can drop blacklisted slot values (e.g. aperson.blacklistof pronouns keeps "he" out of{person}, leaving the slot unresolved for a later CONTEXT-1 §7 fill or re-prompt).Mirrors the already-merged
<intent>.blacklistsuppression loading, extending it to entities and slots.Changes
register_entity_fileloads the sibling<entity>.blacklistand passes it toregister_padatious_entity, which emits it as ablacklistfield on thepadatious:register_entitypayload.register_intent_filescans every{slot}the template declares, loads each sibling<slot>.blacklist, and passes a{slot: [phrases]}map toregister_padatious_intent, emitted asslot_blackliston thepadatious:register_intentpayload.[]/{}), so the payload shape stays stable and backward compatible. A missing.blacklistyields an empty result (no error).Tests
New
TestSlotBlacklistFileintest_skill.pyplus fixtures (person.entity+person.blacklistwithhe/she,thing.blacklist): entity registers with the blacklist phrases; intent registers with per-slot exclusions keyed by slot; absent files give empty (back-compat). Existing exact-signature assertions intest_base.py/test_intent_service_interface.pyupdated for the new kwargs.🤖 Generated with Claude Code