fix: require ovos-core with OVOS-CONTEXT-1 set_context mirror#459
fix: require ovos-core with OVOS-CONTEXT-1 set_context mirror#459JarbasAl wants to merge 1 commit into
Conversation
test_intent_layers_e2e drives IntentLayers gating through the live adapt pipeline, which reads context from session.intent_context. That map is only populated once ovos-core mirrors set_context/remove_context into it (OpenVoiceOS/ovos-core#804). Floor-pin ovos-core to the release carrying that fix so the intent-layers e2e goes green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The code stars have aligned. Here's the update. ✨I've aggregated the results of the automated checks for this PR below. 🔍 LintJust a quick heads-up on the latest check. 🛎️ ❌ ruff: issues found — see job log ⚖️ License CheckReading the fine print with a magnifying glass. 🔍 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 📋 Repo HealthEnsuring the repo's skin is clear (aka linting errors). ✨ ✅ All required files present. Latest Version: ✅ 🔨 Build TestsThe automated workshop has finished its shift. 🛠️
❌ 3.10: Build OK, install failed Your friendly neighborhood bot 🕷️ |
Why
test/unittests/skills/test_intent_layers_e2e.pyis red ondev: anIntentLayers-gated step intent that should match returnsNone. Root cause is not in ovos-workshop — the CONTEXT-1-migrated adapt pipeline gates/injects context fromsession.intent_context, butskill.set_context()(via ovos-core'sadd_context/remove_contexthandlers) only maintained the legacy frame-stacksession.context. So the layer token never reached matching.The fix lives in ovos-core: OpenVoiceOS/ovos-core#804 mirrors
set_contextintosession.intent_context. TheIntentLayersimplementation here needs no change (a skill-side write can't survive the wholesale session fold; it must be done server-side).Change
Floor-pin the
[test]extra to the ovos-core release carrying the mirror (>=2.5.1a1). This unblocks the intent-layers e2e (and therefore any workshop PR whosebuild_testswere red on those 2 tests, e.g. #458).🤖 Generated with Claude Code