Skip to content

fix: require ovos-core with OVOS-CONTEXT-1 set_context mirror#459

Draft
JarbasAl wants to merge 1 commit into
devfrom
fix/intent-layers-e2e-core-pin
Draft

fix: require ovos-core with OVOS-CONTEXT-1 set_context mirror#459
JarbasAl wants to merge 1 commit into
devfrom
fix/intent-layers-e2e-core-pin

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Jul 3, 2026

Copy link
Copy Markdown
Member

Why

test/unittests/skills/test_intent_layers_e2e.py is red on dev: an IntentLayers-gated step intent that should match returns None. Root cause is not in ovos-workshop — the CONTEXT-1-migrated adapt pipeline gates/injects context from session.intent_context, but skill.set_context() (via ovos-core's add_context/remove_context handlers) only maintained the legacy frame-stack session.context. So the layer token never reached matching.

The fix lives in ovos-core: OpenVoiceOS/ovos-core#804 mirrors set_context into session.intent_context. The IntentLayers implementation here needs no change (a skill-side write can't survive the wholesale session fold; it must be done server-side).

Change

Floor-pin the [test] extra to the ovos-core release carrying the mirror (>=2.5.1a1). This unblocks the intent-layers e2e (and therefore any workshop PR whose build_tests were red on those 2 tests, e.g. #458).

Blocked on ovos-core#804 merging and its alpha publishing. Kept as draft until then.

🤖 Generated with Claude Code

test_intent_layers_e2e drives IntentLayers gating through the live adapt
pipeline, which reads context from session.intent_context. That map is only
populated once ovos-core mirrors set_context/remove_context into it
(OpenVoiceOS/ovos-core#804). Floor-pin ovos-core to the release carrying
that fix so the intent-layers e2e goes green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 182a46fa-0eb6-4451-a25e-e7a6eb3d1b5b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/intent-layers-e2e-core-pin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the fix label Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

The code stars have aligned. Here's the update. ✨

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

Just a quick heads-up on the latest check. 🛎️

ruff: issues found — see job log

⚖️ License Check

Reading the fine print with a magnifying glass. 🔍

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

📋 Repo Health

Ensuring the repo's skin is clear (aka linting errors). ✨

✅ All required files present.

Latest Version: 9.2.0a1

ovos_workshop/version.py — Version file
README.md — README
LICENSE — License file
pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
CHANGELOG.md — Changelog
ovos_workshop/version.py has valid version block markers

🔨 Build Tests

The automated workshop has finished its shift. 🛠️

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

❌ 3.10: Build OK, install failed
❌ 3.11: Build OK, install failed
❌ 3.12: Build OK, install failed
❌ 3.13: Build OK, install failed
❌ 3.14: Build OK, install failed
Check job logs for details.


Your friendly neighborhood bot 🕷️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant