Skip to content

#128 windows virtual fact support for proxmox/qemu #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hedius wants to merge 3 commits into
base: main
Choose a base branch
from
Open

#128 windows virtual fact support for proxmox/qemu #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f589254
#128 - add qemu/generic kvm support to windows virtualization fact
Hedius Jun 16, 2026
c0cff0b
128# - add proxmox/qemu test
Hedius Jun 16, 2026
8e7c3e1
remove empty line
Hedius Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/facter/resolvers/windows/virtualization.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def determine_hypervisor_by_manufacturer(comp)
'hyperv'
elsif /^Xen/.match?(manufacturer)
'xen'
elsif /^Amazon EC2/.match?(manufacturer)
elsif /^(Amazon EC2|QEMU)/.match?(manufacturer)
'kvm'
else
'physical'
Expand Down
20 changes: 20 additions & 0 deletions spec/facter/resolvers/windows/virtualization_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,26 @@
end
end

describe '#resolve Proxmox/QEMU VM' do
before do
allow(win32ole).to receive(:Model).and_return(model)
allow(win32ole).to receive(:Manufacturer).and_return(manufacturer)
allow(win32ole).to receive(:OEMStringArray).and_return('')
end

let(:query_result) { [win32ole] }
let(:model) { 'Standard PC (i440FX + PIIX, 1996)' }
let(:manufacturer) { 'QEMU' }

it 'detects virtual machine model' do
expect(Facter::Resolvers::Windows::Virtualization.resolve(:virtual)).to eql('kvm')
end

it 'detects that is virtual' do
expect(Facter::Resolvers::Windows::Virtualization.resolve(:is_virtual)).to be(true)
end
end

describe '#resolve Physical Machine' do
before do
allow(win32ole).to receive(:Model).and_return(model)
Expand Down