v3.0.2#4
Merged
Merged
Conversation
The dynamic-scripts refactor routed commands with
url.startswith("http"), but remote entries are complete command lines
starting with "wget ..." or "opkg ...", so every one of them fell into
the sh "<whole command>" branch and sh tried to open the command line
as a file ("cannot open wget -q ..."). Route on what actually
distinguishes the two kinds: local scripts are absolute paths.
Also sort the dynamic sh/ listing (listdir order is filesystem
dependent, so the tiles appeared in random order) and drop the unused
'icon' assignment that was failing the ruff workflow (F841).
translate_utils.py expects DEBUG, HEADERS and SYSTEM_DIR from the package but they were never defined, so the module could not be imported at all. Define them in __init__.py (HEADERS reuses the plugin's User-Agent, SYSTEM_DIR is the plugin directory where translation_cache.json already lives). File_Commander: use the plugin's gettext catalog so the button labels are translated again, and remove the dead title ternary that compared a constant against a different constant.
Hotfix release: 3.0.1's Script Installer refactor broke every remote entry (wget/opkg command lines were handed to sh as a filename). Version bumped in __init__.py, CONTROL/control, installer.sh and the README badge (which was still at 3.0.0); installer.sh changelog updated for the in-plugin update prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.