Skip to content

Fix floating_point_range numerical values#360

Merged
christophfroehlich merged 1 commit into
mainfrom
fix-floating-point-range
Jun 10, 2026
Merged

Fix floating_point_range numerical values#360
christophfroehlich merged 1 commit into
mainfrom
fix-floating-point-range

Conversation

@christophfroehlich

@christophfroehlich christophfroehlich commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Fixes error on humble like

- generate_parameter_module_example.test.test_params_consistency.TestParamsConsistency test_use_feedforward_commanded_input
  <<< failure message
    AssertionError: The 'to_value' field must be of type 'float'
  >>>

From Iron on, the assertions are disabled per default: https://docs.ros.org/en/rolling/Releases/Release-Iron-Irwini.html#optional-argument-that-hides-assertions-for-messages-class

Question is: Should we instead harden the behavior and wrap the values in a float()?

@christophfroehlich christophfroehlich added the backport-humble Triggers PR backport to ROS 2 humble. label Jun 10, 2026

@saikishor saikishor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

In ROS 1, the params used to auto cast automatically, I don't know if we should do the same here, but I'm okay with this change

@christophfroehlich christophfroehlich merged commit 1f74d68 into main Jun 10, 2026
14 of 15 checks passed
@christophfroehlich christophfroehlich deleted the fix-floating-point-range branch June 10, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants