dnsdist: Implement OTLP RemoteLogger#17618
Draft
pieterlexis wants to merge 6 commits into
Draft
Conversation
Coverage Report for CI Build 28383531898Coverage decreased (-0.05%) to 71.089%Details
Uncovered Changes
Coverage Regressions149 previously-covered lines in 16 files lost coverage.
Coverage Stats💛 - Coveralls |
8767b43 to
a7e72db
Compare
b7b9cbd to
24e6375
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds another kind of RemoteLogger, namely one for OTLP.
At the moment, it is only hooked up for dnsdist's traces. When using OpenTelemetry tracing, this logger and the
SetTraceaction, the DNS processing thread will send the Trace object to this Logger. This means that the protobuf serialization is handled in the RemoteLogger thread, freeing the DNS processing thread for real work.I've opened this PR as a draft for early review and for the CI to do its thing.
Checklist
I have: