Support any start date when extending fixed period memberships#84
Open
Detsieber wants to merge 2 commits into
Open
Support any start date when extending fixed period memberships#84Detsieber wants to merge 2 commits into
Detsieber wants to merge 2 commits into
Conversation
jensschuppe
changed the title
jensschuppe
reviewed
Apr 23, 2026
Contributor
There was a problem hiding this comment.
This looks sensible semantically, however we should run at least the existing tests, and ideally this would add more tests for the newly supported cases (extending fixed-period memberships with variable start dates) - is this something you would be able to provide, @Detsieber?
Also, there are code style issues (indentation, spaces, etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #65