docs(adoption): the axios case study became a real upstream PR#97
Merged
Conversation
…/axios#11062) The near-dupe finding on axios (setFormDataHeaders duplicated across resolveConfig.js and adapters/http.js) was reviewed by hand, consolidated into lib/helpers/setFormDataHeaders.js (keeping the defensive variant), verified against axios's own suite (lint clean, all 89 form-data tests green, the 2 remaining failures reproduced identically on an unmodified checkout), and submitted upstream: axios/axios#11062. Also documents what we deliberately did NOT submit — the hono clusters are behaviorally distinct on inspection (crypto branching; intentional URL-encoding difference) and the zod family is arguably deliberate API symmetry. Detection said "similar"; judgment said "leave them" — the same mechanical-evidence / human-judgment split maintain runs on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strongest possible line in ADOPTION.md: one of the external case-study findings is now a real upstream PR — axios/axios#11062.
setFormDataHeaders+FORM_DATA_CONTENT_HEADERSduplicated verbatim acrosslib/helpers/resolveConfig.jsandlib/adapters/http.js(only a|| {}guard differed)lib/helpers/setFormDataHeaders.js(their one-helper-per-file pattern), keeping the defensive variantEqually important, the doc now records what we didn't submit and why: the hono clusters are behaviorally distinct on inspection (crypto branching; a deliberate URL-encoding difference with an explanatory comment), and the zod family is arguably deliberate API symmetry. Detection said "similar"; judgment said "leave them."
Docs-only.