Skip to content

Fix Isolator cancellation test race condition #9532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosueNina merged 1 commit into from
Jun 15, 2026
+2 −1
Merged

Fix Isolator cancellation test race condition #9532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Tests/Common/IsolatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,14 @@ public void Cancellation()
var ended = false;
var canceled = false;
var result = false;
isolator.CancellationTokenSource.CancelAfter(TimeSpan.FromMilliseconds(100));
try
{
result = isolator.ExecuteWithTimeLimit(
TimeSpan.FromSeconds(5),
() => {
executed = true;
// cancel only once the code block is running so the task can't be canceled before it starts
isolator.CancellationTokenSource.CancelAfter(TimeSpan.FromMilliseconds(100));
Thread.Sleep(5000);
ended = true;
},
Expand Down
Loading